Repository navigation
Fix/4447 linting supressed - #4450
Merged
JulianFlesch merged 31 commits intoOct 16, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…files equally. Remove surfacing errors directly in favor of linting message
…g if applying patch fails
JulianFlesch
marked this pull request as ready for review
August 25, 2026 12:03
mashehu
approved these changes
Oct 2, 2026
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
…files equally. Remove surfacing errors directly in favor of linting message
…g if applying patch fails
…d of referring to the class attribute.
mashehu
reviewed
Oct 15, 2026
mashehu
reviewed
Oct 15, 2026
| mod.get_inputs_from_main_nf() | ||
| mod.get_outputs_from_main_nf() | ||
| mod.get_topics_from_main_nf() | ||
| except Exception as e: # noqa: BLE001 — isolate individual test error from linting run |
Member
There was a problem hiding this comment.
why the noqa here? betterr to be explicit, no?
mashehu
reviewed
Oct 15, 2026
mashehu
left a comment
mashehu
left a comment
Member
There was a problem hiding this comment.
don't like the too general exception handling
mashehu
approved these changes
Oct 15, 2026
mashehu
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nf-core pipelines lintsilently suppresses all module linting on error. #4447 when meta.yml missing, by removing the surfacing of errors early that would supress linting messages.PR checklist
CHANGELOG.mdis updateddocsis updated