Skip to content

Remove ext.use_gpu remnants (superseded by task.accelerator) - #4445

Merged
mashehu merged 6 commits into
nf-core:devfrom
mahesh-panchal:remove-ext-use-gpu
Oct 15, 2026
Merged

mashehu merged 6 commits into
nf-core:devfrom
mahesh-panchal:remove-ext-use-gpu

Conversation

@mahesh-panchal

Copy link
Copy Markdown
Member

Summary

ext.use_gpu is superseded by Nextflow's native task.accelerator directive. This removes the remaining ext.use_gpu references:

  • Removed the redundant ext.use_gpu line from the process_gpu label in the pipeline template's base.config
  • Removed ext.use_gpu from the module linter's permitted ext keys
  • Updated the create wizard's gpu feature help text to describe accelerator instead of a nonexistent use_gpu parameter

The accelerator directive now fully covers GPU scheduling, making the
ext.use_gpu flag unnecessary.
ext.use_gpu is superseded by task.accelerator, so modules using it
should now fail the ext key lint check like any other unrecognized key.
The description referenced a nonexistent use_gpu parameter instead of
the process_gpu label and accelerator directive the feature generates.
@codecov

codecov Bot commented Aug 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.39%. Comparing base (3f64b31) to head (ee5e878).
⚠️ Report is 2 commits behind head on dev.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

No dev-version bump PR has run since the 4.1.0 release, so the
changelog automation's expected running section didn't exist yet.
@mahesh-panchal
mahesh-panchal requested a review from mashehu August 17, 2026 13:07
@mashehu

mashehu commented Oct 2, 2026

Copy link
Copy Markdown
Member

@nf-core-bot fix linting

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

⚠️ Cannot proceed with deployment

This Action has been explicity configured to prevent deployments from forks. You can change this via this Action's inputs if needed

@mashehu
mashehu force-pushed the remove-ext-use-gpu branch from bb3185a to 3d3e37d Compare October 2, 2026 14:39
@mashehu
mashehu enabled auto-merge (squash) October 15, 2026 15:08
@codspeed

codspeed Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will improve performance by 18.38%

⚡ 1 improved benchmark
✅ 8 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_modules_install_startup 6.7 s 5.7 s +18.38%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mahesh-panchal:remove-ext-use-gpu (ee5e878) with dev (77ba349)1

Open in CodSpeed

Footnotes

  1. No successful run was found on dev (cfba18b) during the generation of this report, so 77ba349 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@mashehu
mashehu merged commit fc17087 into nf-core:dev Oct 15, 2026
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants