Repository navigation
Add support to Apple container in tools #4444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mribeirodantas
wants to merge
35
commits into
dev
Choose a base branch
from
support2appleContainer
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
9b35ede
Add basic support to Apple container
mribeirodantas 01219ae
Add support to Apple container downloading images
mribeirodantas a14bd27
Finishing touches to the Apple container support
mribeirodantas 2c8137a
[automated] Fix code linting
nf-core-bot 6fac7ca
Add snapshot file for RunTestWorkflow (apple_container)
mribeirodantas 6a0f043
'nf-core modules test module --profile' now supports apple container
mribeirodantas 34cc95e
Update Textual snapshots for Apple Container feature
mribeirodantas 92173be
Merge branch 'dev' into support2appleContainer
mribeirodantas 57ab00f
feat(appleContainer): enable Wave arm64 provisioning and document limits
mribeirodantas 617d9c7
Add mock build registry so CI stops complaining about nextflow inspect
mribeirodantas 3e8e906
fix(test): don't route mock container fixture through Wave in appleCo…
mribeirodantas 9ef2889
fix(ci): pin Nextflow version in CodSpeed workflow
Copilot f4171b6
fix(appleContainer): emulate amd64 by default instead of Wave/arm64-only
mribeirodantas e372c38
Fix linting error in GitHub Action
mribeirodantas 867220d
feat(appleContainer): make appleContainerWave a self-contained, selec…
mribeirodantas 21abd60
Apply suggestion from reviewer
mribeirodantas 81dea56
Apply batched suggestions from code review
mribeirodantas 55e2308
Revert this change
mribeirodantas c0b6844
add appleContainerWave to usage docs
mribeirodantas e8e1071
Update apple container profile names to snake case capitalization
mribeirodantas 3ed8494
Rename the apple_container_wave profile to apple_container_arm64
mribeirodantas 18239ea
Accept reviewer comments by @mashehu
mribeirodantas b17bfc1
Merge branch 'dev' into support2appleContainer
mribeirodantas 8c744fc
Make comment less verbose
mribeirodantas 722a9eb
Update nf_core/pipeline-template/docs/usage.md
mribeirodantas 16edf25
Apply batched suggestions from code review
mribeirodantas 373b26a
Apply batched suggestions from code review
mribeirodantas 6b88ee4
Apply suggestion from @mashehu
mribeirodantas f87bc40
Check that Apple Container services are running before download
mribeirodantas 17561b0
Detect Apple Container pull/save failures and add integration tests
mribeirodantas 4d11ba8
Fix linting error by removing trailler space
mribeirodantas cf223fc
Make it clear what Rosetta version is required
mribeirodantas b16c1b5
Merge branch 'dev' into support2appleContainer
mribeirodantas 862f7f5
Update snapshot/test
mribeirodantas 970b86b
Fix apple_container snapshot
mribeirodantas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| { | ||
| "-profile test": { | ||
| "content": [ | ||
| { | ||
| "FASTQC": { | ||
| "fastqc": "0.13.0" | ||
| }, | ||
| "Workflow": { | ||
| "my-prefix/testpipeline": "v1.0.0dev" | ||
| } | ||
| }, | ||
| [ | ||
| "fastqc", | ||
| "fastqc/SAMPLE1_PE_1_fastqc.html", | ||
| "fastqc/SAMPLE1_PE_1_fastqc.zip", | ||
| "fastqc/SAMPLE1_PE_2_fastqc.html", | ||
| "fastqc/SAMPLE1_PE_2_fastqc.zip", | ||
| "fastqc/SAMPLE2_PE_1_fastqc.html", | ||
| "fastqc/SAMPLE2_PE_1_fastqc.zip", | ||
| "fastqc/SAMPLE2_PE_2_fastqc.html", | ||
| "fastqc/SAMPLE2_PE_2_fastqc.zip", | ||
| "fastqc/SAMPLE3_SE_1_fastqc.html", | ||
| "fastqc/SAMPLE3_SE_1_fastqc.zip", | ||
| "fastqc/SAMPLE3_SE_2_fastqc.html", | ||
| "fastqc/SAMPLE3_SE_2_fastqc.zip", | ||
| "multiqc", | ||
| "multiqc/multiqc_data", | ||
| "multiqc/multiqc_data/fastqc-status-check-heatmap.txt", | ||
| "multiqc/multiqc_data/fastqc_overrepresented_sequences_plot.txt", | ||
| "multiqc/multiqc_data/fastqc_per_base_n_content_plot.txt", | ||
| "multiqc/multiqc_data/fastqc_per_base_sequence_quality_plot.txt", | ||
| "multiqc/multiqc_data/fastqc_per_sequence_gc_content_plot_Counts.txt", | ||
| "multiqc/multiqc_data/fastqc_per_sequence_gc_content_plot_Percentages.txt", | ||
| "multiqc/multiqc_data/fastqc_per_sequence_quality_scores_plot.txt", | ||
| "multiqc/multiqc_data/fastqc_sequence_counts_plot.txt", | ||
| "multiqc/multiqc_data/fastqc_sequence_duplication_levels_plot.txt", | ||
| "multiqc/multiqc_data/fastqc_sequence_length_distribution_plot.txt", | ||
| "multiqc/multiqc_data/fastqc_top_overrepresented_sequences_table.txt", | ||
| "multiqc/multiqc_data/llms-full.txt", | ||
| "multiqc/multiqc_data/multiqc.log", | ||
| "multiqc/multiqc_data/multiqc.parquet", | ||
| "multiqc/multiqc_data/multiqc_citations.txt", | ||
| "multiqc/multiqc_data/multiqc_data.json", | ||
| "multiqc/multiqc_data/multiqc_fastqc.txt", | ||
| "multiqc/multiqc_data/multiqc_general_stats.txt", | ||
| "multiqc/multiqc_data/multiqc_software_versions.txt", | ||
| "multiqc/multiqc_data/multiqc_sources.txt", | ||
| "multiqc/multiqc_plots", | ||
| "multiqc/multiqc_plots/pdf", | ||
| "multiqc/multiqc_plots/pdf/fastqc-status-check-heatmap.pdf", | ||
| "multiqc/multiqc_plots/pdf/fastqc_overrepresented_sequences_plot.pdf", | ||
| "multiqc/multiqc_plots/pdf/fastqc_per_base_n_content_plot.pdf", | ||
| "multiqc/multiqc_plots/pdf/fastqc_per_base_sequence_quality_plot.pdf", | ||
| "multiqc/multiqc_plots/pdf/fastqc_per_sequence_gc_content_plot_Counts.pdf", | ||
| "multiqc/multiqc_plots/pdf/fastqc_per_sequence_gc_content_plot_Percentages.pdf", | ||
| "multiqc/multiqc_plots/pdf/fastqc_per_sequence_quality_scores_plot.pdf", | ||
| "multiqc/multiqc_plots/pdf/fastqc_sequence_counts_plot-cnt.pdf", | ||
| "multiqc/multiqc_plots/pdf/fastqc_sequence_counts_plot-pct.pdf", | ||
| "multiqc/multiqc_plots/pdf/fastqc_sequence_duplication_levels_plot.pdf", | ||
| "multiqc/multiqc_plots/pdf/fastqc_sequence_length_distribution_plot.pdf", | ||
| "multiqc/multiqc_plots/pdf/fastqc_top_overrepresented_sequences_table.pdf", | ||
| "multiqc/multiqc_plots/png", | ||
| "multiqc/multiqc_plots/png/fastqc-status-check-heatmap.png", | ||
| "multiqc/multiqc_plots/png/fastqc_overrepresented_sequences_plot.png", | ||
| "multiqc/multiqc_plots/png/fastqc_per_base_n_content_plot.png", | ||
| "multiqc/multiqc_plots/png/fastqc_per_base_sequence_quality_plot.png", | ||
| "multiqc/multiqc_plots/png/fastqc_per_sequence_gc_content_plot_Counts.png", | ||
| "multiqc/multiqc_plots/png/fastqc_per_sequence_gc_content_plot_Percentages.png", | ||
| "multiqc/multiqc_plots/png/fastqc_per_sequence_quality_scores_plot.png", | ||
| "multiqc/multiqc_plots/png/fastqc_sequence_counts_plot-cnt.png", | ||
| "multiqc/multiqc_plots/png/fastqc_sequence_counts_plot-pct.png", | ||
| "multiqc/multiqc_plots/png/fastqc_sequence_duplication_levels_plot.png", | ||
| "multiqc/multiqc_plots/png/fastqc_sequence_length_distribution_plot.png", | ||
| "multiqc/multiqc_plots/png/fastqc_top_overrepresented_sequences_table.png", | ||
| "multiqc/multiqc_plots/svg", | ||
| "multiqc/multiqc_plots/svg/fastqc-status-check-heatmap.svg", | ||
| "multiqc/multiqc_plots/svg/fastqc_overrepresented_sequences_plot.svg", | ||
| "multiqc/multiqc_plots/svg/fastqc_per_base_n_content_plot.svg", | ||
| "multiqc/multiqc_plots/svg/fastqc_per_base_sequence_quality_plot.svg", | ||
| "multiqc/multiqc_plots/svg/fastqc_per_sequence_gc_content_plot_Counts.svg", | ||
| "multiqc/multiqc_plots/svg/fastqc_per_sequence_gc_content_plot_Percentages.svg", | ||
| "multiqc/multiqc_plots/svg/fastqc_per_sequence_quality_scores_plot.svg", | ||
| "multiqc/multiqc_plots/svg/fastqc_sequence_counts_plot-cnt.svg", | ||
| "multiqc/multiqc_plots/svg/fastqc_sequence_counts_plot-pct.svg", | ||
| "multiqc/multiqc_plots/svg/fastqc_sequence_duplication_levels_plot.svg", | ||
| "multiqc/multiqc_plots/svg/fastqc_sequence_length_distribution_plot.svg", | ||
| "multiqc/multiqc_plots/svg/fastqc_top_overrepresented_sequences_table.svg", | ||
| "multiqc/multiqc_report.html", | ||
| "pipeline_info", | ||
| "pipeline_info/testpipeline_software_mqc_versions.yml" | ||
| ], | ||
| [ | ||
| "fastqc-status-check-heatmap.txt:md5,0f1975c565a16bf09be08a05c204ded7", | ||
| "fastqc_overrepresented_sequences_plot.txt:md5,4ccee85de50285e09cb9236cdb9ad5e1", | ||
| "fastqc_per_base_n_content_plot.txt:md5,037692101c0130c72493d3bbfa3afac1", | ||
| "fastqc_per_base_sequence_quality_plot.txt:md5,bfe735f3e31befe13bdf6761bb297d6e", | ||
| "fastqc_per_sequence_gc_content_plot_Counts.txt:md5,7108d19c46ef7883e864ba274c457d2e", | ||
| "fastqc_per_sequence_gc_content_plot_Percentages.txt:md5,23f527c80a148e4f34e5a43f6e520a90", | ||
| "fastqc_per_sequence_quality_scores_plot.txt:md5,a0cc0e6df7bfb05257da1cfc88b13c50", | ||
| "fastqc_sequence_counts_plot.txt:md5,c6e4e1588e6765fe8df27812a1322fbd", | ||
| "fastqc_sequence_duplication_levels_plot.txt:md5,3cde2db4033f6c64648976d1174db925", | ||
| "fastqc_sequence_length_distribution_plot.txt:md5,e82b9b14a7e24c0c5f27af97cebb6870", | ||
| "multiqc_citations.txt:md5,4c806e63a283ec1b7e78cdae3a923d4f", | ||
| "multiqc_fastqc.txt:md5,b40bf936b2521dfb491235737669cbd7", | ||
| "multiqc_general_stats.txt:md5,0b54e4e764665bd57fe0f95216744a78" | ||
| ] | ||
| ], | ||
| "meta": { | ||
| "nf-test": "0.9.3", | ||
| "nextflow": "25.10.4" | ||
| }, | ||
| "timestamp": "2026-03-06T10:45:17.184283" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do i need here both architectures, but not in the
pipelines lintcommand?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it's
module test, so the user must decide if they want to build/run with emulation (apple_container) or build the container image (with apple_container_arm64). As for linting, linting checks every architecture, so I don't see a reason for the user to pick one or the other.