Skip to content

Merging template updates 4.2.2 - #333

Merged
LouisLeNezet merged 6 commits into
nf-core:devfrom
LouisLeNezet:merging-template-updates
Nov 16, 2026
Merged

LouisLeNezet merged 6 commits into
nf-core:devfrom
LouisLeNezet:merging-template-updates

Conversation

@LouisLeNezet

Copy link
Copy Markdown
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@LouisLeNezet LouisLeNezet self-assigned this Nov 13, 2026
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5d49dc2

+| ✅ 220 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in CHANGELOG.md: ## v1.2.0dev - [unreleased replace with date on release ]

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 4.2.2
  • Run at 2026-11-16 11:15:15

@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

❌ nf-test failed with latest Nextflow version

Note

Tests with Nextflow's latest version failed but it will not cause a CI workflow failure.
Please check if the failure is expected with newer (edge-)releases of Nextflow or if it needs fixing.

  • ❌ docker | latest-everything | Shard 1/8

See the full run for details.

@erikrikarddaniel erikrikarddaniel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with Claude Code: I went through the full diff and checked the PR head.

CI is green on both Nextflow versions, and the sync looks right. A few small things:

  • awsfulltest.yml pins nf-schema@2.7.2, but nextflow.config pins 2.7.3. I'd keep them in line (suggestion inline).
  • The template's "TODO nf-core: You can customise AWS full pipeline tests" comment came back in the merge (suggestion inline).
  • .gitignore lost *.code-workspace and *.xml.bkp when taking the template side. Intentional?

Approving, since none of this blocks the merge.

Comment thread .github/workflows/awsfulltest.yml Resolved
Comment thread .github/workflows/awsfulltest.yml Resolved
Comment thread .gitignore Resolved
Co-authored-by: Daniel Lundin <erik.rikard.daniel@gmail.com>
@LouisLeNezet
LouisLeNezet merged commit 84ccb36 into nf-core:dev Nov 16, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants