Repository navigation
[stable33] fix(files): await FilesSettings before mounting - #9343
Merged
Merged
Conversation
Co-authored-by: memurats <Mauro-Efisio.Mura@t-systems.com> Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
requested review from
max-nextcloud,
mejo- and
silverkszlo
as code owners
October 7, 2026 10:34
mejo-
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃摑 Summary
Files settings from Text (folder description toggle) were not shown on Nextcloud 33/34 since #8535 switched
FilesSettingstodefineAsyncComponent.With Vue 2 the root instance is mounted detached, so
vm.$mount().$elis still the async placeholder comment node at registration time. Once the component resolves, Vue replacesvm.$el, but the Files app keeps the stale comment node, so nothing renders. Awaiting the import before mounting restores the previous behaviour. Vue 3 branches (stable35, main) are not affected.Reported and fixed by @memurats in nextmcloud#3.
馃弫 Checklist
npm run lint/npm run stylelint/composer run cs:check)馃 AI (if applicable)