fix(conversations): apply the selected preset's parameters when creating a conversation - #6649
fix(conversations): apply the selected preset's parameters when creating a conversation#6649AndyScherzinger wants to merge 1 commit into
Conversation
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/33898044737/artifacts/9946813233 |
eb2dcca to
b6bd25c
Compare
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/33950426057/artifacts/9964745178 |
…ing a conversation The creation screen sent only the preset identifier, but the endpoint derives just the conversation attributes from it and stores whatever parameters the request carried. Voice rooms were therefore neither listable nor expiring, and channels granted call and media permissions instead of reactions only. Allowing guests now sets the room type, so the switch creates a public conversation instead of having no effect, and the password travels in the creation request where the server supports it. Servers without conversation-creation-all are served by follow up requests instead, which no longer discard a conversation that was already created when one of them fails. Assisted-by: Claude Code:claude-opus-5 Claude-Session: https://claude.ai/code/session_014YnDswTbCmRrVETnwE4twB Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
b6bd25c to
0d12eca
Compare
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/33961731118/artifacts/9968253024 |
The conversation creation screen sent only the preset identifier to the creation endpoint. That
endpoint derives just the conversation attributes from it and stores whatever parameters the request
carried, so the parameters of the selected conversation type never arrived:
(257), which contradicts our own
nc_channel_descriptionstring.roomTypewas hardcoded to group, so nopublic conversation was ever created, and the password was then set on a private one.
On top of that the redundant
POST /listableafter creation is gone, the voice room type is hiddenwhere calls are disabled server wide, and servers without
conversation-creation-allare served byfollow-up requests instead of silently losing the participants, the description and the listable
state.
This is the first of three stacked PRs; the conversation types themselves move to the presets
endpoint in the follow-up.
🖼️ Screenshots
No visual change other than the voice room type being hidden where calls are disabled server wide,
so no before/after shots.
🚧 TODO
🏁 Checklist
/backport to stable-xx.xCapabilities checked:
conversation-creation-all,conversation-creation-password(added here),conversation-presets,announcement-presetandconfig => call => enabled.🤖 AI (if applicable)
🤖 Generated with Claude Code
https://claude.ai/code/session_014YnDswTbCmRrVETnwE4twB