Skip to content

Moved simple edit button to avoid covering text - #3328

Merged
tobiasKaminsky merged 4 commits into
mainfrom
move-simple-edit-buttons
Aug 31, 2026
Merged

Moved simple edit button to avoid covering text#3328
tobiasKaminsky merged 4 commits into
mainfrom
move-simple-edit-buttons

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Fix #3241
Fix #2852
Rework of PR #3246

OP PR fixed the reported problems but introduced a crash (in a piece of code not related to the change), so it couldn't be merged as-is. Details on this: #3246 (comment)
I merged it to this branch, fixed the crash and placed in review so hopefully it can be merged and the two issues closed.

🖼️ Screenshots

Please see original PR here: #3246

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

chrissooo and others added 4 commits August 10, 2026 09:48
…ver note text

Signed-off-by: chrissooo <christof@federowicz.de>
Move simple Edit Button from top to right bottom corner to prevent cover
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@daniele-verducci daniele-verducci added this to the 34.1.0 milestone Aug 28, 2026
@daniele-verducci daniele-verducci changed the title Move simple edit buttons Moved simple edit button to avoid covering text Aug 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/notes-android/actions/runs/33185717500/artifacts/9691892672
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@tobiasKaminsky

Copy link
Copy Markdown
Member

I guess #3294 can then also be closed?

@tobiasKaminsky
tobiasKaminsky merged commit d68049e into main Aug 31, 2026
16 checks passed
@tobiasKaminsky
tobiasKaminsky deleted the move-simple-edit-buttons branch August 31, 2026 11:14
@daniele-verducci

Copy link
Copy Markdown
Contributor Author

I guess #3294 can then also be closed?

Yes, it addresses the same issue. I'll close it.

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

First couple of lines covered in note start-editor-button moved to notes top

3 participants