You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat: return Error objects for all error responses - #3578
No actionable comments were generated in the recent review.
Walkthrough
Recipe and category controller errors now return messages in a msg field. A missing recipe response returns “Recipe not found.” instead of the requested recipe ID. The affected HTTP status codes remain unchanged. The internal and public API specifications now reference the shared Error schema for these responses, and the category-rename specification includes a 400 response.
Merge Risk: Minimal · up to 423a8
Error responses for the listed endpoints now return an object with a msg field, and the change is documented as unpublished API changes. No actionable merge-blocking risk remains.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly summarizes the main change: error responses now use Error objects.
Description check
The description includes the required Topic and Scope, Concerns/issues, and Formal requirements sections. It summarizes the affected endpoints, status codes, tests, and API documentation. The Matrix n…
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description includes the required Topic and Scope, Concerns/issues, and Formal requirements sections. It summarizes the affected endpoints, status codes, tests, and API documentation. The Matrix notification checkbox remains unchecked for this API change.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 6 functions across 4 files. (3 skipped: 3 unsupported.)
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #3538 (stacked).
Topic and Scope
All remaining error responses return an
Errorobject ({msg}) instead of a plain string, as suggested in the #3538 review.GET /recipes/{id}DELETE /recipes/{id}GET /search/{query},/category/{category},/tags/{keywords}PUT /category/{category}Concerns/issues
API change, documented in the API changelog. Status codes are unchanged; replacing the remaining 5xx can be discussed separately.
Formal requirements
AI disclosure
I used AI for code gen.