Repository navigation
fix: remove file/line leak from error responses and add debug dump - #3511
Closed
TheTisiboth wants to merge 2 commits into
Closed
TheTisiboth wants to merge 2 commits into
TheTisiboth wants to merge 2 commits into
Conversation
Add structured logging throughout the recipe import pipeline:
- Tag ImportExceptions with a step property (download/parse_html/extract_recipe)
- Log per-parser failures with reasons in RecipeExtractionService
- Add debug logs in HTML parsers (JSON-LD element count, decode errors, microdata itemscope count)
- Log HTTP status, content-type, and response size after download
- Return structured {msg, step} error responses from the import API
- Catch generic exceptions as HTTP 500 with safe translated message
Assisted-by: Claude Code (claude-opus-4-6)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Léo Jan <leo.jan@doctolib.com>
Remove internal file paths and line numbers from JSON error responses
in update() and create() endpoints — these leak server internals to
the client. Return only {msg} consistently.
On extraction failure, dump the first 8KB of downloaded HTML at debug
log level so admins can inspect what was fetched.
Assisted-by: Claude Code (claude-opus-4-6)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Léo Jan <leo.jan@doctolib.com>
Contributor
TheTisiboth
force-pushed
the
feat/enhance-import-logging
branch
from
October 26, 2026 21:55
8efea9f to
e3dc968
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Topic and Scope
Stacked on #3510. Addresses #3279.
file/linefrom JSON error responses inupdate()andcreate()— these leak server internals to the clientFormal requirements
Note
This PR was created with the assistance of AI tools.
Assisted-by: Claude Code (claude-opus-4-6)
🤖 Generated with Claude Code