Conversation
10624a2 to
8ef58f7
Compare
Assisted-by: ClaudeCode:claude-opus-5.5 Signed-off-by: Edward Ly <contact@edward.ly>
Signed-off-by: Edward Ly <contact@edward.ly>
8ef58f7 to
3378a48
Compare
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review limit reachedNext included review available in 11 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe confirmation dialog now displays the largest impulse radius associated with proposed actions. It shows a radius icon, label, and description. The note card uses a warning type when any action is destructive and an info type otherwise. Priority: ➖ Normal Merge Risk: 🟡 Moderate · up to The dialog can understate an unknown action’s warning or misdescribe where deletion may occur. Correct those messages before merging, and make the detailed radius description available without hover. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 22346da1-6618-42be-bb49-3f8e566a2303
📒 Files selected for processing (1)
src/components/ChattyLLM/AgencyConfirmation.vue
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
…ing destructive agent actions Signed-off-by: Edward Ly <contact@edward.ly>
…ve states of agent actions Signed-off-by: Edward Ly <contact@edward.ly>
3378a48 to
1f364d1
Compare
| // show the largest radius among all actions | ||
| // for actions with an undefined or unknown radius, assume they are external | ||
| const largest = this.actions.reduce((max, action) => { | ||
| const index = radiusOrder.indexOf(action?.impulse_radius) |
There was a problem hiding this comment.
You are assuming the assistant PHP API will just give you impulse_radius and destructive from /check_generation, but without making any changes there I don't see how this should be the case.
There was a problem hiding this comment.
Is there another way to retrieve that info from the tools? I haven't seen anything else so far.
There was a problem hiding this comment.
Check my PR. Impulse radius and destrucive attributes of a context agent interaction task are returned here: https://github.com/nextcloud/context_agent/pull/236/changes#diff-305e63f17441090583e8f7affee7120e17c3017bfcd1eb38b27150af3707bf06R297-R308
We need to store these in the database in assistant, likely somewhere around here: https://github.com/nextcloud/assistant/blob/main/lib/Listener/ChattyLLMTaskListener.php#L156-L161. We cannot change the content of the 'actions' output, because people may still be using old versions of assistant.
2 participants
Related: nextcloud/context_agent#236
The highest impulse radius among all pending actions is now added in the bottom-left of the confirmation dialog. Hovering over it also shows a more detailed description just like the help button.
Example for destructive actions:
Assisted-by: ClaudeCode:claude-opus-5.5
🤖 AI (if applicable)