Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
LinuxandWindowsworkflows each get akeepalivejob (liskin/gh-workflow-keepalive@v1) that runs only on their weekly schedule and re-enables its own workflow. The(sources regeneration)check step now also regenerates intosrcand fails when that changes the committed sources.keepalivejob withactions: writeinbuild_linux.ymlandbuild_windows.yml; the action keeps only the workflow it runs in alive, so each scheduled workflow carries its ownzserio tutorial.zs -python build/gen, the step runszserio tutorial.zs -python src -ignoreTimestamps+git add --intent-to-add --all -- src+git diff --exit-code -- src; new files count as drift too-ignoreTimestampsis needed: without it zserio skips output files that are newer thantutorial.zs, so a hand edit passes the checkVerified:
git diff": in a fresh clone with pipzserio==2.19.0, the committed sources → exit 0; a committed body edit insrc/tutorial/role.py→ exit 1 with the flag, exit 0 without it (skipped 6 files); an uncommitted new file → exit 160bba3a: 10/10 build jobs pass (build_linux3.9–3.13,build_windows3.8–3.12), including the new diff check; bothkeepalivejobs skipped onpull_requestas intendedactionlinton both workflows → exit 1, 6 findings, all on the existingcheckout@v3,setup-java@v3,setup-python@v4lines, none on lines added here2 files changed, 22 insertions(+)Not verified: the
keepalivejob itself. It runs only onschedule, so its first real run is the next Sunday cron.Closes #2