Repository navigation
fix(OSD): validate OSD called on completely empty OSD .txt file - #95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for series that have a (nearly) empty text entry for their description.
This started causing build errors about a month ago. Surprising it hasn't come up before, but it may be a result of ncss-tech/OSDRegistry#13 combined with an unusual case (entering a single blank line as the description as opposed to a description that is not entered yet)
validateOSD(): Added check after trimming empty lines. Iflength(raw) == 0, logs"EMPTY OSD FILE: %s"and returnsFALSE. Also updatedosd_to_json()to check before passing to.doParseOSD().