Bugzilla webhook authorization - #6786
Open
ayoubdiourin7 wants to merge 2 commits into
Open
Conversation
suhaibmujahid
requested changes
Sep 4, 2026
Comment on lines
+145
to
148
| - An unauthorized request is ignored without | ||
| consuming the dedupe key, leaving the same flag eligible for a later delivery after the | ||
| requester becomes authorized. | ||
|
|
Member
There was a problem hiding this comment.
This is implementation details that are not needed in the docs.
Comment on lines
-157
to
+163
| Configuration is three env vars — `BUGZILLA_WEBHOOK_SECRET` (required, no default), | ||
| `BUGZILLA_WEBHOOK_BOT_LOGIN` and `BUGZILLA_WEBHOOK_DEDUPE_TTL_SECONDS`; see | ||
| [deployment.md](deployment.md). | ||
| Configuration is four env vars — `BUGZILLA_WEBHOOK_SECRET` (required, no default), | ||
| `BUGZILLA_WEBHOOK_BOT_LOGIN`, `BUGZILLA_WEBHOOK_URL` and | ||
| `BUGZILLA_WEBHOOK_DEDUPE_TTL_SECONDS`; see [deployment.md](deployment.md). |
Member
There was a problem hiding this comment.
Maybe we do not even need this.
| _REQUEST_TIMEOUT_SECONDS = 30 | ||
|
|
||
|
|
||
| class BugzillaUserClient: |
Member
Comment on lines
+41
to
+42
| # Bugzilla instance queried to authorize the requesting user. | ||
| url: str = "https://bugzilla.mozilla.org" |
Member
There was a problem hiding this comment.
This does not fit here. You could add it on the main Settings class as bugzilla_api_url. You can add bugzilla_api_key as well.
| bug_id: int | ||
| flag_id: int | ||
| comment: str | ||
| actor_login: str |
Member
There was a problem hiding this comment.
what not calling it user_login to match Bugzilla?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6755