Skip to content

fix(bug 2043228): allow renovate PRs to be created at any hour - #1459

Merged
bhearsum merged 1 commit into
mozilla-releng:masterfrom
bhearsum:fix-bug-2043228-allow-renovate
Jun 2, 2026
Merged

bhearsum merged 1 commit into
mozilla-releng:masterfrom
bhearsum:fix-bug-2043228-allow-renovate

Conversation

@bhearsum

@bhearsum bhearsum commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

From the documentation

Renovate can only update a dependency if both of these conditions are true:

  • The Renovate program is running (on your hardware, or on Mend's hardware)
  • The schedule set in the Renovate config file(s) allows Renovate to look for updates for that dependency

The documentation additionally describes that Mend controls when the Renovate program is running.

With this in mind, I believe the recent changes to restrict Renovate to only running at 2am UTC have resulted in fewer PRs being created. Now that we've made the change to restrict to one day a month, having them opened at any hour shouldn't be a big deal.

From [the documentation](https://docs.renovatebot.com/key-concepts/scheduling/#global-schedule-vs-specific-schedule)

> Renovate can only update a dependency if both of these conditions are true:
>
> * The Renovate program is running (on your hardware, or on Mend's hardware)
> * The schedule set in the Renovate config file(s) allows Renovate to look for updates for that dependency

The documentation additionally describes that Mend controls when the Renovate program is running.

With this in mind, I believe the recent changes to restrict Renovate to only running at 2am UTC have resulted in fewer PRs being created. Now that we've made the change to restrict to one day a month, having them opened at any hour shouldn't be a big deal.
@bhearsum
bhearsum requested a review from a team as a code owner June 1, 2026 10:57
@Eijebong

Eijebong commented Jun 1, 2026 •

Copy link
Copy Markdown
Contributor

Doesn't this mean that we could get multiple PRs on the same day?

Edit: Meant to comment this on the reps one (mozilla-releng/reps#92), got bamboozled by the same PR being opened in all repos that required it and me not checking. But discussing it here works too.

@bhearsum

bhearsum commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Doesn't this mean that we could get multiple PRs on the same day?

Edit: Meant to comment this on the reps one (mozilla-releng/reps#92), got bamboozled by the same PR being opened in all repos that required it and me not checking. But discussing it here works too.

As I understand it, yeah, it could. The alternative is set a wider hour range (eg: 0-6 like before), but that still runs the risk of multiple PRs a day (and also missing PRs entirely). My opinion is that now that we're restricting the day of the month that running at any hour ought to be fine, even if we occasionally get more than one PR for the same thing in the same repo on the two days out of the month that it runs.

@bhearsum
bhearsum merged commit a25e21a into mozilla-releng:master Jun 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants