Repository navigation
加上学院标签 - #138
Merged
Merged
加上学院标签#138
Conversation
成员可以给学院贴管理员预设的标签,3 人以上贴的才算这个学院的标签(总体设计 §9.3)。 - college_tags、college_tag_votes 表(迁移 0007),归 programs 模块,先放设计里的 5 个预设 - 贴和撤回:每人每个标签一票,禁言的不能贴(权限加一级 contribute:没禁言的成员) - 学院页列出全部预设、几个人贴了、自己贴了没有,点一下贴上、再点撤回;算数的标签写在学院名称下面和院校清单里 - 总表和院校清单能按标签筛选,选几个就要同时有这几个;总表的 tableVersion 算上贴的票 - 管理员在学院页看谁贴的,删一票或清空;「管理 · 学院标签」加、改、调顺序、删除预设,删除前提示有几票;这些都记进操作日志
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联
二期的「学院标签」(总体设计 §17、§9.3),没有对应的 Issue,进展见路线图 #2。
改了什么
成员可以给学院贴管理员预设的标签,3 人以上贴的才算这个学院的标签。
college_tags、college_tag_votes表(迁移0007_college_tags.sql),归programs模块,先放设计里的 5 个预设contribute:没禁言的成员,反馈、求收录以后也用它)tableVersion算上贴的票,贴完回到浏览器缓存的总表会重新取怎么验证的
pnpm check(135 个测试)通过;另起一个库跑过pnpm build、pnpm db:migrate、pnpm db:codegen --verifypnpm check:学院页名称下的标签和每个标签的人数取自同一次计数;删预设先锁住它再删票,日志里记的是真删掉的票;删除前的提示按设计改成人数(一个人在几个学院贴的算一个);管理页的长说明能折行没改的:
304,筛选项到下一次变动才更新。投票都是一条语句的短事务,窗口只有几毫秒,所以照订阅的做法,没为它加计数行影响
0007_college_tags.sql,加两张表和 5 个预设,不动已有数据PUT、DELETE /colleges/{id}/tags/{tag},GET /colleges/{id}/tags/{tag}/votes,DELETE /admin/tag-votes/{id},DELETE /admin/colleges/{id}/tags/{tag},GET、POST /admin/tags,PATCH、DELETE /admin/tags/{id};总表的学院、院校清单和学院页多了tags,学院页多了tag_counts