Skip to content

[DSD-11077]Update images.txt - #1931

Merged
abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
bhumi46:patch-13
Nov 19, 2026
Merged

abhishek8shankar merged 1 commit into
mosip:release-1.2.0.1from
bhumi46:patch-13

Conversation

@bhumi46

@bhumi46 bhumi46 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Consolidated several identity-related service image references under a shared image. This updates the service images used for deployment; no end-user functionality changes are noted.

Signed-off-by: Bhuminathan M <thisisbn46@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The VIDIVI image list replaces five service image references, each tagged release-1.3.x, with one mosipdev/id-repository-service reference tagged IDREPO-1583-consolidate-idrepo-services.

Changes

VIDIVI image reference update

Layer / File(s) Summary
Consolidated image reference
release/vidivi/images.txt
Replaces the identity, credential, credential-request-generator, VID, and salt-generator image entries with one mosipdev/id-repository-service entry.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: ivanmeneges

Merge Risk: Low · up to d04ef

This change swaps five service images in the VIDIVI transfer list for one consolidated image tagged with a feature-branch name. The row format is valid and the checkout contains no consumer of the removed images. Before releasing, confirm that deployments expect the consolidated image and that the feature-branch tag is intentional.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Inconclusive The title "DSD-11077Update images.txt" names a file and a ticket ID but not the substance of the change. The raw summary shows the PR replaces five service image references in release/vidivi/images.… Rewrite the title to state the change. For example: "DSD-11077 Consolidate identity, credential, VID and salt-generator images into id-repository-service in vidivi release". Keep the ticket prefix.
Passed Passed checks: 3 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "DSD-11077Update images.txt" names a file and a ticket ID but not the substance of the change. The raw summary shows the PR replaces five service image references in release/vidivi/images.txt with mosipdev/id-repository-service tagged IDREPO-1583-consolidate-idrepo-services. The title is vague and generic and does not convey which images changed or why.

Resolution

Rewrite the title to state the change. For example: "DSD-11077 Consolidate identity, credential, VID and salt-generator images into id-repository-service in vidivi release". Keep the ticket prefix.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Five image names depart the page
One consolidated tag takes stage
A shorter list records the change
The image entry stands in range
Ready for the next release page

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI; Enforced overrides: Organization
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 33794277-f3bb-4373-b1fb-5b164bd190d8
Commits

Reviewing files that changed from the base of the PR and between c4d890a and d04ef6d.

Files selected for processing: 1

  • release/vidivi/images.txt

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@abhishek8shankar
abhishek8shankar merged commit b6e0a6a into mosip:release-1.2.0.1 Nov 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants