Skip to content

[soil] [1.2.1.x] Fix missing onboarder bucket: partner-onboarder uses the copied s3 secret - #565

Merged
bhumi46 merged 1 commit into
mosip:soilfrom
bhumi46:soil/1.2.1.x-onboarder-minio-secret
Nov 20, 2026
Merged

bhumi46 merged 1 commit into
mosip:soilfrom
bhumi46:soil/1.2.1.x-onboarder-minio-secret

Conversation

@bhumi46

@bhumi46 bhumi46 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Refs #287

Error

On mosip-platform-1.2.1.x, the onboarder bucket is never created in MinIO and the partner-onboarder reports are not uploaded. Job log (#287):

S3_USER_SECRET: password
mc: <ERROR> Unable to initialize new alias from the provided credentials. The request signature we calculated does not match ...
mc: <ERROR> Unable to make bucket `s3/onboarder`. The AWS Access Key Id you provided does not exist in our records.

Root cause

  • The onboarder image (mosip-onboarding/upload-reports.sh) runs mc alias set with the s3-user-key / s3-user-secret env vars, then mc mb s3/onboarder --ignore-existing, then copies the reports. So the bucket is created only when the login works.
  • partner-onboarder 1.3.1 (mosip-dsf) creates its own secret s3-partner-onboarder with the default s3-user-secret: password. Nothing overrides it, so the login fails.

Fix

  • hooks/partner-onboarder-setup.sh (pre-install) already copies secret s3 into onboarder. That secret is created by s3-setup.sh in namespace s3 and holds the MinIO root password, or the external S3 credentials.
  • The DSF now references it:
    extraEnvVarsSecret[0]: "keycloak"
    extraEnvVarsSecret[1]: "keycloak-client-secrets"
    extraEnvVarsSecret[2]: "s3"
  • The chart renders extraEnvVarsSecret after its own secret in envFrom. When a key appears in more than one source, the last one wins, so s3-user-secret comes from the copied secret.
  • keycloak and keycloak-client-secrets, the chart defaults, are listed as well. An indexed set replaces the whole default list.
Chart Used by Own S3 secret Default extraEnvVarsSecret Change
partner-onboarder 1.3.1 mosip-dsf partner-onboarder s3-<release> = password keycloak, keycloak-client-secrets this PR
partner-onboarder 12.0.1 esignet-dsf onboarders none s3, keycloak, keycloak-client-secrets none needed: already reads the copied s3

Backward compatibility

  • Only mosip-platform-1.2.1.x/mosip-dsf.yaml changes; there are no workflow changes.
  • The hook already copied s3, so there is no new dependency and no new failure path.

Testing

  • helm template mosip/partner-onboarder --version 1.3.1 with this release's exact set values gives these envFrom secrets, in order: s3-partner-onboarder, keycloak, keycloak-client-secrets, s3.
  • Also checked: an indexed set alone (extraEnvVarsSecret[0]=s3) drops the keycloak secrets, which is why all three are listed.
  • Still to do on an env: re-run helmsman_mosip, then check that the job log no longer shows S3_USER_SECRET: password, that the bucket gets created, and that mc ls s3/onboarder lists the reports.

Note: mosip-platform-1.2.0.x has the same issue. It is not changed here; the scope is 1.2.1.x.

🤖 Generated with Claude Code

@bhumi46 bhumi46 self-assigned this Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 17

  • ^main$
  • ^master$
  • ^master-java21$
  • ^develop$
  • ^develop2$
  • ^develop/.*
  • ^release$
  • ^release/.*
  • ^release-.*
  • ^\d+.\d+.x$
  • ^\d+.\d+.\d+$
  • ^hotfix/.*
  • ^hotfix-.*
  • ^issue-.*
  • develop
  • release-*
  • MOSIP*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI; Enforced overrides: Organization
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: c45d9a37-2658-4144-9a66-549a782a9de7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

…ecret (mosip#287)

The onboarder job logs in to MinIO with s3-user-key/s3-user-secret and runs
"mc mb --ignore-existing onboarder" before uploading reports. partner-onboarder
1.3.1 creates its own secret s3-partner-onboarder with the default
s3-user-secret "password", so mc login failed and the onboarder bucket was
never created.

hooks/partner-onboarder-setup.sh already copies secret s3 (from ns s3, made by
s3-setup.sh: MinIO root password or external S3 creds) into ns onboarder.
Reference it via extraEnvVarsSecret, after the chart secret so it wins in
envFrom. keycloak and keycloak-client-secrets are listed too because an
indexed set replaces the chart default list.

No workflow change. esignet-dsf is unchanged: partner-onboarder 12.0.1
already reads the copied s3 secret by default.

Signed-off-by: Bhuminathan M <thisisbn46@gmail.com>
@bhumi46
bhumi46 force-pushed the soil/1.2.1.x-onboarder-minio-secret branch from a4d7cc8 to fd334c8 Compare November 20, 2026 07:12
@bhumi46 bhumi46 changed the title [soil] [1.2.1.x] Fix missing onboarder bucket: pass MinIO root password to partner-onboarders [soil] [1.2.1.x] Fix missing onboarder bucket: partner-onboarder uses the copied s3 secret Nov 20, 2026
@bhumi46
bhumi46 marked this pull request as ready for review November 20, 2026 08:32
@bhumi46
bhumi46 merged commit 722deea into mosip:soil Nov 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant