Repository navigation
[soil] [1.2.1.x] Fix missing onboarder bucket: partner-onboarder uses the copied s3 secret - #565
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 17
Please check the settings in the CodeRabbit UI or the
|
…ecret (mosip#287) The onboarder job logs in to MinIO with s3-user-key/s3-user-secret and runs "mc mb --ignore-existing onboarder" before uploading reports. partner-onboarder 1.3.1 creates its own secret s3-partner-onboarder with the default s3-user-secret "password", so mc login failed and the onboarder bucket was never created. hooks/partner-onboarder-setup.sh already copies secret s3 (from ns s3, made by s3-setup.sh: MinIO root password or external S3 creds) into ns onboarder. Reference it via extraEnvVarsSecret, after the chart secret so it wins in envFrom. keycloak and keycloak-client-secrets are listed too because an indexed set replaces the chart default list. No workflow change. esignet-dsf is unchanged: partner-onboarder 12.0.1 already reads the copied s3 secret by default. Signed-off-by: Bhuminathan M <thisisbn46@gmail.com>
bhumi46
force-pushed
the
soil/1.2.1.x-onboarder-minio-secret
branch
from
November 20, 2026 07:12
a4d7cc8 to
fd334c8
Compare
bhumi46
marked this pull request as ready for review
November 20, 2026 08:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #287
Error
On
mosip-platform-1.2.1.x, theonboarderbucket is never created in MinIO and the partner-onboarder reports are not uploaded. Job log (#287):Root cause
mosip-onboarding/upload-reports.sh) runsmc alias setwith thes3-user-key/s3-user-secretenv vars, thenmc mb s3/onboarder --ignore-existing, then copies the reports. So the bucket is created only when the login works.s3-partner-onboarderwith the defaults3-user-secret: password. Nothing overrides it, so the login fails.Fix
hooks/partner-onboarder-setup.sh(pre-install) already copies secrets3intoonboarder. That secret is created bys3-setup.shin namespaces3and holds the MinIO root password, or the external S3 credentials.extraEnvVarsSecretafter its own secret inenvFrom. When a key appears in more than one source, the last one wins, sos3-user-secretcomes from the copied secret.keycloakandkeycloak-client-secrets, the chart defaults, are listed as well. An indexedsetreplaces the whole default list.extraEnvVarsSecretmosip-dsfpartner-onboarders3-<release>=passwordesignet-dsfonboarderss3Backward compatibility
mosip-platform-1.2.1.x/mosip-dsf.yamlchanges; there are no workflow changes.s3, so there is no new dependency and no new failure path.Testing
helm template mosip/partner-onboarder --version 1.3.1with this release's exactsetvalues gives theseenvFromsecrets, in order:s3-partner-onboarder,keycloak,keycloak-client-secrets,s3.extraEnvVarsSecret[0]=s3) drops the keycloak secrets, which is why all three are listed.helmsman_mosip, then check that the job log no longer showsS3_USER_SECRET: password, that the bucket gets created, and thatmc ls s3/onboarderlists the reports.Note:
mosip-platform-1.2.0.xhas the same issue. It is not changed here; the scope is 1.2.1.x.🤖 Generated with Claude Code