Skip to content

[issue # 1827] Fixed IDA local client setup issues. - #1832

Merged
mahammedtaheer merged 6 commits into
mosip:develop-1764from
mahammedtaheer:develop-1764
Nov 22, 2026
Merged

mahammedtaheer merged 6 commits into
mosip:develop-1764from
mahammedtaheer:develop-1764

Conversation

@mahammedtaheer

@mahammedtaheer mahammedtaheer commented Nov 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Improvements
    • The sample client now allows authentication requests to omit date of birth and excludes fields that have no value.
    • The verifiable credential exchange prompts for a KYC token and provides clearer feedback when the token is empty.
    • Updated sample requests demonstrate date-of-birth fields and a fuller set of identity details.

Signed-off-by: Mahammed Taheer <mohd.taheer@gmail.com>
Signed-off-by: Mahammed Taheer <mohd.taheer@gmail.com>
Signed-off-by: Mahammed Taheer <mohd.taheer@gmail.com>
Signed-off-by: Mahammed Taheer <mohd.taheer@gmail.com>
Signed-off-by: Mahammed Taheer <mohd.taheer@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 22, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The sample client now accepts requests without a date of birth, omits unset demographics fields during authentication, and updates CLI response output, the VCI token prompt, local configuration, and sample request data.

Changes

IDA Sample Client

Layer / File(s) Summary
Demographics model and sample requests
authentication/local-dev-setup/IDA-sample-client/client/authenticator/model/auth_request.py, authentication/local-dev-setup/IDA-sample-client/samples/*
DemographicsModel.dob is optional. Sample requests add dates of birth, update one VID, and add a request with identity and contact fields.
Omit unset demographics fields
authentication/local-dev-setup/IDA-sample-client/client/authenticator/authenticator.py
Both authentication paths serialize demographics without fields set to None.
CLI output, prompts, and local configuration
authentication/local-dev-setup/IDA-sample-client/client/authenticator/cli_options.py, authentication/local-dev-setup/IDA-sample-client/client/authenticator/main.py, .gitignore
Response error output uses a shared helper. The VCI prompt requests kycToken. Dynaconf configuration removes /app/token_seeder.conf, and ignore patterns use the authentication/ prefix.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related issues

Possibly related PRs

Suggested reviewers: ckm007, mohanachandran-s

Merge Risk: Minimal · up to 82e8d

This change makes date of birth optional in the local IDA sample client, adds sample requests, and tidies CLI output and local configuration. It affects only the local development sample tooling. No concrete defect was found. Whether a given IDA deployment accepts requests without a date of birth depends on its configuration and can be confirmed by running the samples against that deployment.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "[issue # 1827] Fixed IDA local client setup issues." matches the main change. The changeset fixes IDA local client setup by updating the .gitignore paths, the authenticator's request handli…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "[issue # 1827] Fixed IDA local client setup issues." matches the main change. The changeset fixes IDA local client setup by updating the .gitignore paths, the authenticator's request handling, the CLI KYC token flow, the config file list, the DemographicsModel dob field, and the sample request files. The title names the issue number and the area, so a teammate scanning history can identify the primary change. It does not list the specific fixes, which the title does not need to do.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A missing date may now be spared
Unset fields leave the request bare
Errors gather in one place
The token prompt names its case
Sample requests gain details anew

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI; Enforced overrides: Organization
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a761bf7e-000a-4ce2-b341-153a28e8e954
Commits

Reviewing files that changed from the base of the PR and between a08aacf and 82e8d02.

Files selected for processing: 14

  • .gitignore
  • authentication/local-dev-setup/IDA-sample-client/client/authenticator/authenticator.py
  • authentication/local-dev-setup/IDA-sample-client/client/authenticator/cli_options.py
  • authentication/local-dev-setup/IDA-sample-client/client/authenticator/main.py
  • authentication/local-dev-setup/IDA-sample-client/client/authenticator/model/auth_request.py
  • authentication/local-dev-setup/IDA-sample-client/samples/auth-req-02.json
  • authentication/local-dev-setup/IDA-sample-client/samples/auth-req-03.json
  • authentication/local-dev-setup/IDA-sample-client/samples/auth-req-04.json
  • authentication/local-dev-setup/IDA-sample-client/samples/auth-req-05-vid.json
  • authentication/local-dev-setup/IDA-sample-client/samples/auth-req-06-vid.json
  • authentication/local-dev-setup/IDA-sample-client/samples/auth-req-07-vid-1time.json
  • authentication/local-dev-setup/IDA-sample-client/samples/auth-req-08-vid-5trans.json
  • authentication/local-dev-setup/IDA-sample-client/samples/auth-req-09.json
  • authentication/local-dev-setup/IDA-sample-client/samples/auth-req-11.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Signed-off-by: Mahammed Taheer <57249563+mahammedtaheer@users.noreply.github.com>
@mahammedtaheer
mahammedtaheer merged commit aface19 into mosip:develop-1764 Nov 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant