Repository navigation
fix(dialog): label reply media instead of falling back - #365
Merged
gdlbo merged 1 commit intoOct 13, 2026
Merged
Conversation
voice messages, video notes and audio had no label in a reply preview. if you replied to one of them without a caption, the preview just said "reply". the composer bar was worse - it showed "photo" for every kind of media. both places now share one list of labels, taken from strings that already exist. no new strings added. related to monogram-android#178 but does not close it. the main part of that issue - highlighting the message you jump to - is still not done. checked with: ./gradlew.bat :feature:dialog:test -PskipNativeBuild=true git diff --check
Sanderovich2
force-pushed
the
fix/dialog-reply-media-labels
branch
from
October 7, 2026 18:03
4156d63 to
d2403a0
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
voice messages, video notes and audio had no label in a reply preview. so if you replied to one of them without a caption, the preview just said "reply".
the composer bar was worse - it showed "photo" for every kind of media, even for voice messages.
now both places share one list of labels and use strings that already exist. no new strings added.
this is related to #178 but does not close it. the main part of that issue - highlighting the message you jump to - is still not done.
(sorry about my previous pr. my english is not good and the description i wrote there did not match what the code actually did. i already closed it.)