Repository navigation
Support Rocq 9.1, 9.2, and 9.3, drop Rocq 9.0 - #217
Open
miriampolzer wants to merge 1 commit into
Open
miriampolzer wants to merge 1 commit into
miriampolzer wants to merge 1 commit into
Conversation
miriampolzer
force-pushed
the
bump-rocq-9.2-9.3
branch
from
November 13, 2026 08:12
7cf6cc6 to
96f7a27
Compare
Add Rocq 9.3 alongside 9.1, 9.2, and dev in CI, bump rocq-core to >= 9.1~, and replace the pre-8.14 unsupported-attributes warning override with -deprecated-since-9.3,-deprecated-since-9.2, and -deprecated-from-Coq.
JasonGross
force-pushed
the
bump-rocq-9.2-9.3
branch
from
November 14, 2026 00:42
96f7a27 to
ace783a
Compare
Collaborator
|
Why are we dropping 9.0? Seems needless here |
Contributor
Author
|
I want to clean up old deprecations and warnings, and for that I need to make the cut at some version. From talking to @andres-erbsen a while ago my understanding was that we guarantee the latest two rocq versions, and because some CI runners are still behind I picked 9.1-9.3. Supporting fewer versions is usually less work, so better for us. And I can clean up more deprecations. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Rocq 9.3 alongside 9.1, 9.2, and
devin CI, bumprocq-coreto>= 9.1~, and replace the pre-8.14unsupported-attributeswarning override with-deprecated-since-9.3,-deprecated-since-9.2,-deprecated-from-Coq.Part of mit-plv/fiat-crypto#2237.