Consolidate MiniPdf contribution guidance - #162
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The updated tracked benchmark report includes a future/ambiguous “Generated” timestamp (missing timezone) and AGENTS.md has a minor heading-structure issue that should be corrected before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR consolidates contributor guidance for MiniPdf rendering/visual-benchmark improvements into a single skill document, removes legacy agent-specific orchestration assets, and refreshes the tracked DOCX benchmark comparison report to match the current LibreOffice reference output.
Changes:
- Move/centralize the contribution workflow guidance into
.claude/skills/minipdf-contribution/SKILL.mdand point AGENTS.md at it. - Remove obsolete agent skills/commands and the PowerShell “contribution loop” orchestration scripts under
.github/skills/(and the wrapper underscripts/). - Synchronize the “Quick contribution” prompt across README translations and update the tracked DOCX comparison report content/labels.
File summaries
| File | Description |
|---|---|
| tests/MiniPdf.Benchmark/reports_docx/comparison_report.md | Refresh tracked DOCX benchmark comparison report content/labels and scores. |
| scripts/Invoke-MiniPdfContributionLoop.ps1 | Remove legacy wrapper script for the old contribution-loop controller. |
| README.md | Replace quick-start agent prompt with the consolidated skill invocation. |
| documents/README.zh-TW.md | Sync quick-start prompt with English README. |
| documents/README.zh-CN.md | Sync quick-start prompt with English README. |
| documents/README.ko.md | Sync quick-start prompt with English README. |
| documents/README.ja.md | Sync quick-start prompt with English README. |
| documents/README.it.md | Sync quick-start prompt with English README. |
| documents/README.fr.md | Sync quick-start prompt with English README. |
| CONTRIBUTING.md | Remove the now-obsolete automated rendering improvement section that referenced the retired loop tooling. |
| AGENTS.md | Point contributors to the consolidated .claude/skills/minipdf-contribution/SKILL.md guidance and simplify agent guidelines. |
| .github/skills/sync-readme-translations/SKILL.md | Remove the old README translation sync skill. |
| .github/skills/skill-minipdf-contribution/SKILL.md | Remove the legacy Copilot-specific contribution skill. |
| .github/skills/skill-minipdf-contribution/scripts/select-candidates.ps1 | Remove legacy contribution-loop selector script. |
| .github/skills/skill-minipdf-contribution/scripts/resolve-implementation.ps1 | Remove legacy implementation resolver. |
| .github/skills/skill-minipdf-contribution/scripts/preflight.ps1 | Remove legacy preflight checks script. |
| .github/skills/skill-minipdf-contribution/scripts/contribution-loop.ps1 | Remove legacy contribution-loop controller. |
| .github/skills/skill-minipdf-contribution/assets/pull-request-template.md | Remove legacy PR template associated with the retired loop. |
| .github/skills/create-release/SKILL.md | Remove legacy release skill document. |
| .cursor/commands/minipdf-contribution.md | Remove legacy Cursor command wrapper for the retired loop. |
| .claude/skills/minipdf-contribution/SKILL.md | Add the consolidated, vendor-neutral contribution guidance skill document. |
| .claude/commands/minipdf-contribution.md | Remove legacy Claude command wrapper for the retired loop. |
| .agents/skills/minipdf-contribution/SKILL.md | Remove legacy agents skill document for the retired loop. |
Review details
- Files reviewed: 22/23 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # Agent Instructions | ||
|
|
||
| For MiniPdf rendering or visual benchmark contributions, read and follow `.claude/skills/minipdf-contribution/SKILL.md`. | ||
| # Agent Guidelines |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (23)
💤 Files with no reviewable changes (12)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change removes legacy MiniPdf contribution commands, scripts, and workflow documentation. It adds a Claude Code skill with benchmark-based diagnosis and validation steps. Repository and translated README guidance now directs contributors to the new skill. ChangesMiniPdf contribution workflow
Priority: ⬇️ Low — Defer this contribution-guidance consolidation because it changes documentation and agent workflow without direct runtime product impact. Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The consolidated contribution workflow is internally consistent, with no concrete merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/skills/minipdf-contribution/SKILL.mdValidation
git diff --cached --checkSummary by CodeRabbit
Documentation
Removed Capabilities