-
Notifications
You must be signed in to change notification settings - Fork 1
Expand benchmark to three runtimes #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,10 +20,10 @@ pwsh ./scripts/compare-nuget-v1-rust.ps1 | |
| ``` | ||
|
|
||
| This harness builds a local `MiniExcel.Rust` package, resolves the latest stable public MiniExcel v1 | ||
| package, restores both into an isolated `net8.0` consumer, and compares `MiniExcel.Query` with | ||
| `MiniExcelRust.Query`. Before timing, it verifies every row, column, and normalized value. Cold and | ||
| steady scenarios run in alternating fresh processes and report query time, first-row latency, | ||
| managed allocation, peak working set, and peak private memory to | ||
| package, restores both into an isolated `net8.0` consumer, and compares `MiniExcel.Query`, | ||
| `MiniExcelRust.Query`, and native `MiniExcel::query`. Before timing, it verifies every row, column, | ||
| and normalized value across all three paths. Cold and steady scenarios run in rotating fresh | ||
| processes and report query time, first-row latency, managed allocation where applicable, peak working set, and peak private memory to | ||
| `target/benchmarks/nuget-v1/benchmark-<rid>.{json,md}`. | ||
|
|
||
| Use `-Rows`, `-Columns`, `-Iterations`, `-Passes`, and `-WarmupPasses` to change the load. The | ||
|
|
@@ -33,12 +33,17 @@ Arm64. Pass `-MiniExcelVersion 1.46.0` to pin a historical baseline for reproduc | |
| #### Latest NuGet Result | ||
|
|
||
| The 2026-09-10 Windows x64 run used 100,000 rows x 10 columns and five fresh processes per runtime | ||
| and scenario. `MiniExcel 1.46.0` and `MiniExcel.Rust 0.1.0-preview.1` matched every normalized value. | ||
| and scenario. `MiniExcel 1.46.0`, `MiniExcel.Rust 0.1.0-preview.1` through .NET, and native | ||
| `MiniExcel Rust 0.4.0` matched every normalized value. | ||
|
Comment on lines
35
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win Make the latest-result provenance unambiguous.
📍 Affects 2 files
🤖 Prompt for AI Agents |
||
|
|
||
| | Scenario | MiniExcel | MiniExcel.Rust | Rust speedup | Allocation reduction | Working-set reduction | | ||
| | --- | ---: | ---: | ---: | ---: | ---: | | ||
| | Cold | 2,052.91 ms | 1,278.59 ms | 1.61x | 88.6% | 4.6% | | ||
| | Steady | 4,635.98 ms | 3,380.16 ms | 1.37x | 88.6% | 10.1% | | ||
| | Scenario | Runtime | Median elapsed | Rows/s | First row | Managed allocation | Peak working set | | ||
| | --- | --- | ---: | ---: | ---: | ---: | ---: | | ||
| | Cold | MiniExcel | 2,598.50 ms | 38,484 | 1,051.97 ms | 2,541.93 MB | 50.93 MB | | ||
| | Cold | MiniExcel.Rust (.NET) | 1,899.42 ms | 52,648 | 450.85 ms | 289.36 MB | 49.64 MB | | ||
| | Cold | MiniExcel.Rust | 1,220.82 ms | 81,912 | 537.17 ms | n/a | 4.14 MB | | ||
| | Steady | MiniExcel | 5,997.76 ms | 50,019 | 616.40 ms | 7,625.15 MB | 52.80 MB | | ||
| | Steady | MiniExcel.Rust (.NET) | 4,202.10 ms | 71,393 | 442.59 ms | 868.05 MB | 48.79 MB | | ||
| | Steady | MiniExcel.Rust | 3,344.20 ms | 89,708 | 467.30 ms | n/a | 4.20 MB | | ||
|
|
||
| ## Fairness Controls | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: mini-software/MiniExcel-Rust
Length of output: 27244
🏁 Script executed:
Repository: mini-software/MiniExcel-Rust
Length of output: 166
Align the methodology scope with the NuGet harness.
In both documents,
ScopeandFairness Controlsdescribe two runners and use “both” for validation and measurement controls. The NuGet harness compares three paths:MiniExcel.Query,MiniExcelRust.Query, and nativeMiniExcel::query. Update the methodology for all three runtimes, or state that it applies only to the legacy two-runtime report.📍 Affects 2 files
docs/dotnet-v1-query-benchmark.md#L23-L26(this comment)docs/dotnet-v1-query-benchmark.zh-CN.md#L23-L26🤖 Prompt for AI Agents