Repository navigation
fix(render): preserve NOT in negated NULL predicates - #16
Open
Sivadheeraj5356 wants to merge 2 commits into
Open
Sivadheeraj5356 wants to merge 2 commits into
Sivadheeraj5356 wants to merge 2 commits into
Conversation
…ates Handle SQLAlchemy NULL conditions in expressions.
Add a test to ensure NOT IS NULL predicates render correctly.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mindsdb/mindshub#12491.
Use bare sa.null() for NULL right operands of IS / IS NOT so SQLAlchemy preserves predicate inversion. Adds regression coverage for negated and plain NULL checks.
Testing: the new test fails before the fix and passes after it. Renderer suite: 16 passed, 1 pre-existing skip. Broader suites weren't run because they require full handler dependencies.