You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Re-running a failed docs deployment failed because the prior attempt's
github-pages artifact remained, making deploy-pages find two artifacts.
Use a per-attempt artifact name, and allow workflow_dispatch.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…#584)
* docs(skill): keep framework-specific docs/scripts when consumer is not on TUnit
Library.Template AGENTS.md and test scripts assume TUnit. Tell mergers to retain
xunit/VSTest docs, FailsInCloudTest filters, bespoke dotnet-test-cloud.ps1 behavior,
unused-package hygiene, and repo-specific pipeline steps when those are not equivalent
to the template.
* docs(skill): traversal coverage, non-test projects under test/, placeholders, bespoke NativeAOT flows
Lessons from Copilot review of the 2026-10 template merge wave
(Nerdbank.Json#37, ShapeShift#17, Nerdbank.JsonRpc#114, Nerdbank.MessagePack#1091).
* docs(skill): never re-add GitVersionBaseDirectory in repos with nested version.json
* Avoid the literal placeholder token in the update-library-template skill
Expand-Template.ps1 fails if any remaining file contains the placeholder token, so describe it instead of quoting it.
* Fix expansion check
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Resolve conflicts by preserving repository-specific solution structure, keeping the current README, and removing template-only files. Apply the incoming TUnit migration to the existing test projects and update their docs and runner behavior. Adapt NativeAOT compatibility validation to Microsoft.VisualStudio.Validation, while leaving dynamic test assemblies managed-only.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Authenticate docs validation to Azure Artifacts with GitHub OIDC
Add immutable-subject federation setup with additive branch trust and readable credential names.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Match Azure Artifacts credentials to configured NuGet source names
Derive environment credential keys from nuget.config so downstream feeds such as msft_consumption_public authenticate during tool restore.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Skip docs feed authentication outside the Microsoft organization
Preserve anonymous restore for the template and other owners while retaining fork and Dependabot restrictions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
* Authenticate same-repository Dependabot documentation checks
Remove the actor exclusion while preserving organization and fork restrictions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The template merge removed the NativeAOT test discovery, publish, and execution path. Restore it while retaining project opt-outs and without reintroducing broad warning suppressions.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Correct comment to describe non-test project condition
test/Directory.Build.targets:6
This comment describes test projects, but the condition below applies only when IsTestProject is not true; both actual test projects explicitly keep UseAppHost=true. Update the wording to describe non-test projects so future changes do not invert the condition based on stale guidance.
The reason will be displayed to describe this comment to others. Learn more.
Copilot review overview
🔵 Needs a closer look
Windows CI currently skips NativeAOT dump configuration because it evaluates a PowerShell Core-only variable.
Review effort: Balanced Findings: None
Previously missed (1)
In code that hasn't changed since last review
Windows PowerShell skips NativeAOT hang/crash dump switches
tools/dotnet-test-cloud.ps1:124
Windows CI invokes this script through the powershell: task (azure-pipelines/dotnet.yml:25), which runs Windows PowerShell 5.1. $IsWindows is only defined in PowerShell Core, so this condition is false there and NativeAOT runs silently lose the requested hang/crash dump switches. Use the same $env:OS check already used elsewhere in the repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.