Repository navigation
fix(portal): show full task text for legacy runs - #1480
Gile (Gile987) wants to merge 2 commits into
Conversation
|
Hi. Pardon my impatience. Did anyone take a look at this? |
Wassim Chegham (manekinekko)
left a comment
There was a problem hiding this comment.
Thank you for contributing to Scope, Gile (@Gile987), and for your patience while we got to this review! I appreciate the focused fix, the coverage for hover and keyboard focus, and the matching Storybook and documentation updates. Keeping legacy previews fetch-free while preserving existing linked previews is a good approach.
I found two interaction edge cases worth addressing before merging and left inline comments with suggested fixes and regression coverage. The existing 19 component tests and Portal type check passed; I reproduced both gaps with additional focused tests. Thanks again for helping improve this experience!
Thank you very much. |
Summary
Legacy runs without a task-prompt reference display truncated task text
without a hover preview. Add a Radix tooltip showing the full inline task
on hover or keyboard focus, using the existing 200 ms hover delay.
The tooltip is portaled to avoid table clipping. Existing linked prompt
previews remain unchanged. Truncated numeric filter labels also use Radix
tooltips instead of native title attributes.
Related to #766.
Demos
Before
before.webm
Hovering over a legacy run's truncated task does not reveal the full text.
After
after.webm
Hovering over the same task displays its full text in a styled tooltip.
Testing
pnpm exec vitest run apps/portal/src/components/TaskPromptBadge.test.tsx— all 19 tests passed.
pnpm --filter portal exec tsc --noEmit -p tsconfig.app.json— passed.
pnpm build— passed.pnpm headers:check— passed.viewport positioning, and no additional task-prompt requests.
pnpm test --maxWorkers=2): 3,189 tests passed;seven Windows-worker tests failed because
pwshwas unavailable.pnpm lint: failed because ESLint is unavailable in workspace packages.CI currently documents this limitation and permits that step to fail.
Documentation and compatibility
Updated
docs/architecture/app-design.mdto document legacy task previewsand consistent tooltip timing.
No API, database schema, dependency, or upgrade changes.
CLI capabilities are unchanged; this change affects Portal presentation.
Checklist