fix(evaluate): serialize and parse RegExp values - #3189
Open
FadeHack (FadeHack) wants to merge 1 commit into
Open
fix(evaluate): serialize and parse RegExp values#3189FadeHack (FadeHack) wants to merge 1 commit into
FadeHack (FadeHack) wants to merge 1 commit into
Conversation
serialize_value() had no branch for re.Pattern, so a compiled pattern
passed to evaluate() was silently sent as undefined. parse_value() had
no branch for "r", so a RegExp coming back from the page surfaced as the
raw wire dict instead of a pattern.
Both directions now use the {r: {p, f}} form the driver already
implements. Flags map through the existing escape_regex_flags() helper;
on the way back the JavaScript-only flags (g, y, d, u, v) have no re
equivalent and are dropped.
Fixes: microsoft#3188
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serialize_value()has no branch forre.Pattern, so passing a compiled pattern toevaluate()silently sendsundefined.parse_value()has no branch for"r", so a RegExp coming back from the page reaches the caller as the raw wire dict instead of a pattern:The protocol already carries regexes as
{r: {p, f}}and the driver implements both sides, so this just adds the two missing branches on the Python side. playwright-dotnet does the same inEvaluateArgumentValueConverter.cs.Flags reuse the existing
escape_regex_flags()helper. On the way back, the JavaScript-only flags (g,y,d,u,v) have noreequivalent and are dropped.Fixes #3188