openvmm: discard cancelled snapshot boundary requests - #188
Merged
Merged
Conversation
Advance the OpenVMM gitlink from b9603efc025867a64a66db625fe6275f82a3753a to 240732ce976d5b16b0e854e3500b6815ab1fd2c2. The promoted revision rejects queued snapshot-boundary requests when stop or reset closes their release receiver, before input is gated or vCPUs are stopped. This prevents cancelled work from crossing a later snapshot boundary while preserving live requests and requests queued after cancellation. It also adds component regression coverage for stop/reset cancellation, device destruction, and the normal release/completion handshake.
Copilot started reviewing on behalf of
Pedro Henrique Penna (ppenna)
September 22, 2026 18:53
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The pinned upstream PR remains open and blocked with exact-head checks still running.
Review effort: Balanced
Findings: None
What changed in this PR
Advances the OpenVMM submodule to integrate cancellation handling for stale microVM snapshot-boundary requests.
Changes:
- Updates the OpenVMM gitlink to
240732ce. - Incorporates request filtering before input gating or vCPU stopping.
- Includes upstream regression coverage for cancelled, destroyed, and live requests.
| File | Description |
|---|---|
openvmm |
Pins the OpenVMM revision containing the fix and tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
b9603efc025867a64a66db625fe6275f82a3753ato240732ce976d5b16b0e854e3500b6815ab1fd2c2Testing
Depends-on: nanvix/openvmm#85