Add Azure Linux 3 guest support by Copilot · Pull Request #110 · microsoft/nvx

Copilot · 2026-09-18T16:24:08Z

NVX currently builds an Alpine initramfs exclusively. This change adds Azure Linux 3 as an additional guest option while preserving Alpine defaults.

Guest selection
- Add Azure Linux 3 to initramfs and guest-build configuration.
- Keep Alpine as the default guest.
Azure Linux rootfs
- Build the guest from the public, digest-pinned Azure Linux 3 base image.
- Install the guest runtime utilities and emit an initramfs package manifest.
Coverage
- Add focused CLI and Docker-target tests.

Fixes Support Azure Linux 3 #109

Copilot

Copilot wasn't able to review any files in this pull request.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Íñigo Goiri (goiri) · 2026-09-18T16:44:46Z

Azure Linux 4 is in beta, switching to 3:
https://mcr.microsoft.com/en-us/artifact/mar/azurelinux/base/core/tag/3.0
Repository: azurelinux/base/core
Tag: 3.0
Type: application/vnd.docker.distribution.manifest.list.v2+json
Digest: sha256:34a22db497ff34a0f35ca5fc54bd38711d04238a2c1b2f65d35dc9d45dd82584

Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Copilot

🟡 Changes recommended

The Azure Linux build omits its kernel, while its launcher and package manifest are incompatible with the new rootfs.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (2)

docker/Dockerfile:99

build-guest --guest azurelinux selects this target, but build_docker_artifacts() subsequently requires both vmlinux and initramfs.cpio.gz. A clean build therefore always fails for a missing kernel; an existing destination can instead mask this by reusing a stale kernel. Export the kernel artifacts from this combined target as the Alpine artifacts target does.

FROM scratch AS azurelinux-artifacts
COPY --from=azurelinux-initramfs /tmp/initramfs.cpio.gz /initramfs.cpio.gz
COPY --from=azurelinux-initramfs /tmp/initramfs.cpio.gz.packages.json /initramfs.cpio.gz.packages.json

docker/Dockerfile:80

This manifest is incompatible with the existing release-source pipeline: collect_alpine_sources._load_packages() indexes every package as an object with name and version, while this emits four strings, so collect-sources fails after an Azure Linux build. It also omits packages already present in the base image and transitive installs. Generate an installed-RPM inventory with metadata and make source collection distribution-aware.

        '  "packages": ["e2fsprogs", "iproute", "net-tools", "util-linux"],' \

Files reviewed: 7/7 changed files
Comments generated: 4
Review effort level: Balanced

Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Copilot

🟡 Changes recommended

The Azure Linux image omits required runtime tools and retains an unavailable BusyBox error path.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (1)

docker/Dockerfile:64

The copied init script still calls /bin/busybox reboot -f in fatal(), but Azure Linux base/core does not provide BusyBox and this stage does not install it. Any early boot error therefore reaches a missing command and exits PID 1 instead of reporting the VM exit status. Patch this call to the installed nvx-exit helper (or make init distro-neutral).

    install -m 0755 /tmp/nvx/init /rootfs/init; \
    sed -i 's/ || mdev -s/ || exit 1/' /rootfs/init; \

Files reviewed: 10/10 changed files
Comments generated: 1
Review effort level: Balanced

Íñigo Goiri (goiri) · 2026-09-22T17:27:26Z

Copilot #116 got merged; rebase and make the changes based on it

…109-support-azure-linux # Conflicts: # .github/actions/check-quality/action.yml # SOURCE-MANIFEST.json # doc/usage.md # docker/Dockerfile # guest/common/nvx-container-enter-azurelinux # scripts/nvx.py # scripts/nvx_tools/build.py # scripts/nvx_tools/release.py # scripts/test_nvx_tools.py Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

Azure Linux cannot currently boot successfully, and release packaging, artifact selection, image-pin enforcement, and package manifests remain incomplete.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 2 · 2

Open (4)

Add Azure Linux handling to common init · New
The Azure Linux rootfs is missing runtime dependencies used by the scripts copied below. The Azure…
Use an initramfs-only target for Azure builds · New
Add Azure files to the published release payload · New

Resolved since last review (2)

build-guest --guest azurelinux selects this target, but the target exports only the initramfs. On…
This file replaces the standard package manifest, but release/source tooling unconditionally treats…

+COPY --from=azurelinux-helpers /out/ /rootfs/sbin/
+COPY --from=base /bin/busybox /rootfs/bin/busybox
+RUN set -eux; \
+    install -m 0755 /repo/guest/common/init /rootfs/init; \


+        "guest_sources": ["guest/common"],
+        "package_manifests": ["build/initramfs-azurelinux.cpio.gz.packages.json"],


Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Copilot · 2026-09-22T17:49:22Z

Copilot #116 got merged; rebase and make the changes based on it

Done — merged dev (with PR #116's Ubuntu guest support) into this branch and reconciled the Azure Linux integration with the new GuestDescriptor/guest-build architecture. Verified with the full test_nvx_tools.py suite, ruff, pyright, and shellcheck/shfmt.

Copilot

Copilot review overview

🟡 Changes recommended

Azure boot and managed-lifecycle paths are broken, with additional CI, release, provenance, and build-validation gaps.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 3 · 1

Open (4)

Azure managed lifecycle lacks the required container launcher · New
Add Azure Linux handling to common init
The Azure Linux rootfs is missing runtime dependencies used by the scripts copied below. The Azure…
Add Azure files to the published release payload

Resolved since last review (1)

Use an initramfs-only target for Azure builds

Copilot

Copilot review overview

🟡 Changes recommended

Azure guests cannot boot correctly, and release, provenance, runtime, and CI integration remain incomplete.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 4 · 2

Open (6)

Azure boot fails because common init rejects its identity · New
Azure managed lifecycle lacks the required container launcher
Add Azure Linux handling to common init
The Azure Linux rootfs is missing runtime dependencies used by the scripts copied below. The Azure…
Native all-guests build accepts unsupported Azure Linux descriptor · New
Add Azure files to the published release payload

Previously missed (1)

In code that hasn't changed since last review

CI does not build, upload, or smoke-test Azure guest artifacts

docker/Dockerfile:125

No CI path actually builds this new Docker target. .github/actions/build-guest-artifacts/action.yml only builds/caches Alpine and Ubuntu, and .github/workflows/ci.yml:151-166 uploads the same set; the added unit test mocks Docker execution. Add Azure artifact build/cache/upload steps and an Azure guest boot/identity smoke test so Dockerfile or runtime regressions are detected.

+    initramfs_name="initramfs-azurelinux.cpio.gz",
+    package_manifest_format="azurelinux-v1",
+    default_memory_mib=128,
+    boot_marker=b"NVX-GUEST-BOOT-OK: azurelinux",


+    descriptor.name: descriptor
+    for descriptor in (ALPINE_GUEST, UBUNTU_GUEST, AZURELINUX_GUEST)


…109-support-azure-linux # Conflicts: # scripts/nvx.py # scripts/nvx_tools/build.py Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Copilot

Copilot review overview

🟡 Changes recommended

Critical workload-launch failure and unresolved runtime, release, bundling, reproducibility, and test-coverage issues block approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 3 · 3

Open (6)

Preserve compatible unshare support for Azure workloads · New
Azure boot fails because common init rejects its identity
Add Azure Linux handling to common init
Include Azure manifest in project source archive inputs · New
Native all-guests build accepts unsupported Azure Linux descriptor
Add Azure files to the published release payload

Resolved since last review (2)

Azure managed lifecycle lacks the required container launcher
The Azure Linux rootfs is missing runtime dependencies used by the scripts copied below. The Azure…

+    for utility in awk chroot ifconfig ip mdev mount ping blkid losetup mkfs.ext4 mountpoint flock unshare; do \
+        ln -sf busybox "/rootfs/bin/$utility"; \
+    done; \


+        "guest_sources": ["guest/common"],
+        "package_manifests": ["build/initramfs-azurelinux.cpio.gz.packages.json"],


Initial plan

059d991

Copilot AI self-assigned this Sep 18, 2026

Copilot AI balanced review requested due to automatic review settings September 18, 2026 16:24

Copilot AI assigned Íñigo Goiri (goiri) Sep 18, 2026

Copilot AI reviewed Sep 18, 2026

View reviewed changes

Copilot AI linked an issue Sep 18, 2026 that may be closed by this pull request

Support Azure Linux 3 #109

Open

Copilot started work on behalf of Íñigo Goiri (goiri) September 18, 2026 16:24 View session

Copilot AI changed the title ~~[WIP] Add support for Azure Linux alongside Alpine Linux~~ Add Azure Linux 4 guest support Sep 18, 2026

Copilot finished work on behalf of Íñigo Goiri (goiri) September 18, 2026 16:29

Copilot AI requested a review from Íñigo Goiri (goiri) September 18, 2026 16:29

Copilot started work on behalf of Íñigo Goiri (goiri) September 18, 2026 16:31 View session

Copilot finished work on behalf of Íñigo Goiri (goiri) September 18, 2026 16:32

Copilot started work on behalf of Íñigo Goiri (goiri) September 18, 2026 16:35 View session

Copilot finished work on behalf of Íñigo Goiri (goiri) September 18, 2026 16:36

Copilot started work on behalf of Íñigo Goiri (goiri) September 18, 2026 16:40 View session

Copilot finished work on behalf of Íñigo Goiri (goiri) September 18, 2026 16:41

Copilot started work on behalf of Íñigo Goiri (goiri) September 18, 2026 16:42 View session

Íñigo Goiri (goiri) changed the title ~~Add Azure Linux 4 guest support~~ Add Azure Linux 3 guest support Sep 18, 2026

Add Azure Linux 3 guest support

5d2c779

Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 18, 2026 16:50

Copilot started reviewing on behalf of Íñigo Goiri (goiri) September 18, 2026 16:50 View session

Copilot finished work on behalf of Íñigo Goiri (goiri) September 18, 2026 16:51

Copilot AI reviewed Sep 18, 2026

View reviewed changes

Comment thread docker/Dockerfile Outdated

Comment thread scripts/nvx.py Outdated

Comment thread scripts/nvx_tools/build.py

Comment thread scripts/test_nvx_tools.py Outdated

Íñigo Goiri (goiri) marked this pull request as ready for review September 18, 2026 17:02

Copilot started work on behalf of Íñigo Goiri (goiri) September 18, 2026 17:02 View session

Reject Azure Linux native guest before kernel build

b59623d

Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Copilot finished work on behalf of Íñigo Goiri (goiri) September 18, 2026 17:33

Copilot AI reviewed Sep 18, 2026

View reviewed changes

Comment thread docker/Dockerfile Outdated

Copilot started work on behalf of Íñigo Goiri (goiri) September 22, 2026 17:31 View session

Copilot AI and others added 2 commits September 22, 2026 17:33

Integrate Azure Linux guest framework

c7e84a2

Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 22, 2026 17:36

Address Azure Linux guest review

7515ee6

Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Copilot started reviewing on behalf of Íñigo Goiri (goiri) September 22, 2026 17:39 View session

Copilot AI and others added 2 commits September 22, 2026 17:41

Refine Azure Linux initramfs build

e19544a

Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Harden Azure Linux guest build

639245a

Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Copilot AI reviewed Sep 22, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 22, 2026 17:45

Unify Azure Docker build flow

d6c1bbb

Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Copilot finished work on behalf of Íñigo Goiri (goiri) September 22, 2026 17:47

Copilot started reviewing on behalf of Íñigo Goiri (goiri) September 22, 2026 17:47 View session

Copilot finished work on behalf of Íñigo Goiri (goiri) September 22, 2026 17:49

Copilot AI reviewed Sep 22, 2026

View reviewed changes

Comment thread docker/Dockerfile Outdated

Copilot AI review requested due to automatic review settings September 22, 2026 17:54

Copilot started reviewing on behalf of Íñigo Goiri (goiri) September 22, 2026 17:55 View session

Copilot AI reviewed Sep 22, 2026

View reviewed changes

Copilot started work on behalf of Íñigo Goiri (goiri) September 22, 2026 21:02 View session

Copilot AI and others added 2 commits September 22, 2026 21:04

Merge remote-tracking branch 'origin/dev' into copilot/microsoft-nvx-…

aaee09c

…109-support-azure-linux # Conflicts: # scripts/nvx.py # scripts/nvx_tools/build.py Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Fix Azure Linux guest CI integration

b4f5ed4

Co-authored-by: goiri <3159513+goiri@users.noreply.github.com>

Copilot AI review requested due to automatic review settings September 22, 2026 21:08

Copilot started reviewing on behalf of Íñigo Goiri (goiri) September 22, 2026 21:09 View session

Copilot finished work on behalf of Íñigo Goiri (goiri) September 22, 2026 21:11

Copilot AI reviewed Sep 22, 2026

View reviewed changes

Navigation Menu

Add Azure Linux 3 guest support - #110

Add Azure Linux 3 guest support#110
Íñigo Goiri (goiri) with Copilot wants to merge 16 commits into
devfrom
copilot/microsoft-nvx-109-support-azure-linux

Copilot AI commented Sep 18, 2026 •

edited by goiri

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Íñigo Goiri (goiri) commented Sep 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Íñigo Goiri (goiri) commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		"guest_sources": ["guest/common"],
		"package_manifests": ["build/initramfs-azurelinux.cpio.gz.packages.json"],

		descriptor.name: descriptor
		for descriptor in (ALPINE_GUEST, UBUNTU_GUEST, AZURELINUX_GUEST)

Conversation

Copilot AI commented Sep 18, 2026 • edited by goiri Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Íñigo Goiri (goiri) commented Sep 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (2)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (1)

Uh oh!

Uh oh!

Íñigo Goiri (goiri) commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI commented Sep 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Sep 18, 2026 •

edited by goiri

Loading