Repository navigation
Mitokic/10082026/finn skill - #289
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Launch and update races can overlap runs or modify software during execution, with additional export and configuration inconsistencies.
11 open findings
File lock acquisition is non-atomic · New Active-run check allows package replacement during execution · New Update check races with new forecast launches · New Wide exports silently omit requested prediction intervals · New Ensemble training default conflicts with standard-run policy · New Resume incorrectly discards LLM configuration changes · New Ignored file copy failures create invalid projects · New Failed update falsely reports successful restoration · New Settings card omits ensemble training configuration · New Duplicate recovery documentation references unsupported capability · New Documented update status name is incorrect · New
What changed in this PR
Adds a complete local Finn skill for coding agents, including forecasting workflows, installers, documentation, support forms, and validation. It also improves Copilot authentication guidance.
Changes:
- Adds Finn project, forecast, analysis, export, update, and recovery tooling.
- Adds issue forms, CI validation, installation guidance, and sample data.
- Improves Copilot authentication errors, tests, and documentation.
| File | Description |
|---|---|
.Rbuildignore |
Excludes the skill from package builds. |
.github/ISSUE_TEMPLATE/bug-report.yml |
Adds package bug form. |
.github/ISSUE_TEMPLATE/config.yml |
Configures issue intake. |
.github/ISSUE_TEMPLATE/feature-request.yml |
Adds feature request form. |
.github/ISSUE_TEMPLATE/finn-skill.yml |
Adds Finn support form. |
.github/workflows/R-CMD-check.yaml |
Tests Finn scripts in CI. |
AGENTS.md |
Documents skill layout and validation. |
NEWS.md |
Records authentication improvements. |
R/agent_copilot.R |
Adds actionable authentication help. |
README.md |
Introduces coding-agent usage. |
tests/testthat/test-agent-copilot.R |
Tests authentication guidance. |
vignettes/ai-agent.Rmd |
Documents CLI authentication setup. |
skills/finn/.gitattributes |
Sets script line endings. |
skills/finn/README.md |
Documents installation and usage. |
skills/finn/SKILL.md |
Defines agent behavior and workflows. |
skills/finn/version.json |
Establishes skill version history. |
skills/finn/install_skill.ps1 |
Adds Windows installer. |
skills/finn/install_skill.sh |
Adds macOS/Linux installer. |
skills/finn/examples/sample_monthly.csv |
Provides tutorial data. |
skills/finn/templates/config.template.json |
Provides configuration template. |
skills/finn/templates/data_template.csv |
Provides input-data template. |
skills/finn/scripts/check_env.R |
Checks local prerequisites. |
skills/finn/scripts/diagnose_run.R |
Diagnoses runs and creates reports. |
skills/finn/scripts/export_results.R |
Exports completed forecasts. |
skills/finn/scripts/finn_analysis_helpers.R |
Adds read-only analysis helpers. |
skills/finn/scripts/finn_common.R |
Implements shared runtime utilities. |
skills/finn/scripts/find_rscript.ps1 |
Locates R on Windows. |
skills/finn/scripts/find_rscript.sh |
Locates R on Unix systems. |
skills/finn/scripts/install_finnts.R |
Installs finnts and dependencies. |
skills/finn/scripts/prepare_data.R |
Reshapes and samples input data. |
skills/finn/scripts/profile_data.R |
Profiles data and suggests settings. |
skills/finn/scripts/run_cancel.R |
Cancels background runs. |
skills/finn/scripts/run_forecast.R |
Launches and resumes forecasts. |
skills/finn/scripts/run_status.R |
Reports run progress. |
skills/finn/scripts/run_worker.R |
Executes background forecasts. |
skills/finn/scripts/setup_project.R |
Manages projects and storage. |
skills/finn/scripts/update_skill.R |
Updates and rolls back the skill. |
skills/finn/scripts/validate_config.R |
Validates and presents settings. |
skills/finn/tests/test_skill.R |
Adds offline skill tests. |
skills/finn/references/analysis.md |
Documents result analysis. |
skills/finn/references/choosing-a-run.md |
Guides run selection. |
skills/finn/references/data-and-settings.md |
Documents settings and data changes. |
skills/finn/references/data-requirements.md |
Documents required input shape. |
skills/finn/references/glossary.md |
Defines forecasting terminology. |
skills/finn/references/parallelism.md |
Explains resource allocation. |
skills/finn/references/runs-and-restarts.md |
Documents restart behavior. |
skills/finn/references/setup.md |
Provides setup instructions. |
skills/finn/references/starter-prompts.md |
Supplies example requests. |
skills/finn/references/status-and-debugging.md |
Documents monitoring and debugging. |
skills/finn/references/storage.md |
Explains project storage. |
skills/finn/references/troubleshooting.md |
Maps failures to remedies. |
skills/finn/references/tutorial.md |
Adds first-run tutorial. |
skills/finn/references/updates.md |
Documents updates and rollback. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
smdp2000ofc
reviewed
Oct 12, 2026
smdp2000ofc
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request introduces new GitHub issue templates for bug reports, feature requests, and Finn skill problems, and adds workflow and documentation updates to support the Finn skill for coding agents. It also improves Copilot authentication error messages with actionable guidance and enhances documentation for users who want to run Finn through a coding agent.
GitHub Issue Templates and Workflow Integration:
.github/ISSUE_TEMPLATE/bug-report.yml[1]feature-request.yml[2]finn-skill.yml[3].github/ISSUE_TEMPLATE/config.yml.github/ISSUE_TEMPLATE/config.ymlR1-R5).github/workflows/R-CMD-check.yaml.github/workflows/R-CMD-check.yamlR31-R47)Finn Skill and Coding Agent Support:
README.md[1]AGENTS.md[2].Rbuildignoreto exclude theskillsdirectory from the package build and added.gitattributesfor consistent line endings in Finn skill scripts. (.Rbuildignore[1]skills/finn/.gitattributes[2]Copilot Authentication Improvements:
R/agent_copilot.RR/agent_copilot.RL221-R255)NEWS.mdto document these changes and clarify recent feature and bug fix descriptions. (NEWS.mdNEWS.mdL8-R25)