[HIGH] Patch vitess for CVE-2026-84445 and CVE-2026-83530 - #18903
Merged
jslobodzian merged 1 commit intoSep 18, 2026
Merged
jslobodzian merged 1 commit into
jslobodzian merged 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
v-sushilsati
marked this pull request as draft
September 18, 2026 11:30
v-sushilsati
marked this pull request as ready for review
September 18, 2026 14:23
jslobodzian
approved these changes
Sep 18, 2026
|
Auto cherry-pick results:
Auto cherry-pick pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1206302&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary -
• Patch vitess for CVE-2026-84304 and CVE-2026-84445.
• Upgraded google.golang.org/grpc from v1.65.0 => v1.83.2.
• Upgraded Go version from 1.22.3 => 1.25.0.
• Updated other related Go dependencies and the vendor archive.
• Added go-toolchain-compat.patch to fix Go 1.25+ build breaks caused by the toolchain bump (removal of the runtime.roundupsize linkname and related go vet/formatting issues). More details in issue section.
• Removed obsolete CVE patches whose fixes are included in the refreshed dependencies.
• Vendor Tarball -> vitess-19.0.4-vendor-v2.tar.gz
Changelog -
• deleted: CVE-2024-45339.patch
• deleted: CVE-2025-22868.patch
• deleted: CVE-2025-22870.patch
• deleted: CVE-2026-39821.patch
• deleted: CVE-2026-56852.patch
• new file: CVE-2026-84304.patch
• new file: go-toolchain-compat.patch
• modified: vitess.signatures.json
• modified: vitess.spec
Fixed Issue: Vitess RPM build was failing due to a Go toolchain version conflict.
time="2026-09-17T10:12:34Z" level=debug msg="# vitess.io/vitess/go/cmd/mysqlctl"
time="2026-09-17T10:12:34Z" level=debug msg="link: vitess.io/vitess/go/hack: invalid reference to runtime.roundupsize"
time="2026-09-17T10:12:35Z" level=debug msg="error: Bad exit status from /var/tmp/rpm-tmp.tP97Bw (%build)"
Fix: Pin BuildRequires: golang >= 1.25 and < 1.28 to stay in the compatible 1.25–1.27 window, plus add go-toolchain-compat.patch, which replaces the private runtime.roundupsize linkname with a self-contained allocator size-class implementation (new build-tagged files) and fixes a few other Go-version-dependent code paths.
Added Patch9: go-toolchain-compat.patch, which:
o Replaces the private runtime.roundupsize linker reference with a self-contained allocator size-class calculation, split across build-tagged files (go/hack/atof_go127.go for Go ≥1.27, go/hack/atof_legacy.go for older, plus changes in go/hack/runtime.go).
o Fixes a few other Go-version-dependent issues: rendering of sync.Mutex internals in schemaz output, and explicit format strings for dynamic errors required by newer go vet.
Upstream reference for the roundupsize/size-class implementation:
vitess/go/hack/msize.go at main · vitessio/vitess
Links to CVEs -
• https://nvd.nist.gov/vuln/detail/CVE-2026-84445
• https://nvd.nist.gov/vuln/detail/CVE-2026-83530
Test Methodology -

• Local build was successful.
. buddy build was successful : https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1206152&view=results
Patch Application:
