Handle tsc watch and profiling signals - #64085
Draft
Jake Bailey (jakebailey) wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes unresponsive tsc interruption by scoping signal handling to watch mode and preserving profiling output during termination.
Changes:
- Adds reusable termination-signal utilities.
- Flushes profiles before re-raising termination signals.
- Configures watch-specific cancellation and adds Unix profiling coverage.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tsc/cmd/tsc/main.go |
Configures watch signal handling. |
tsc/internal/execute/tsc.go |
Applies signal contexts to unprofiled watch modes. |
tsc/internal/osutil/osutil.go |
Adds termination notification helpers. |
tsc/internal/osutil/signal_unix.go |
Re-raises Unix signals. |
tsc/internal/osutil/signal_other.go |
Provides the non-Unix fallback. |
tsc/internal/pprof/pprof.go |
Flushes profiles safely upon termination. |
tsc/internal/pprof/pprof_unix_test.go |
Tests profile flushing on SIGINT. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Jake Bailey (jakebailey)
force-pushed
the
redo-redo-4592
branch
from
August 29, 2026 00:31
61776cf to
71421ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63856