Using the appropriate models for MSTeams meeting start/end routes - #619
Merged
Rodrigo Brandão (rodrigobr-msft) merged 3 commits intoOct 2, 2026
Merged
Conversation
Rodrigo Brandão (rodrigobr-msft)
marked this pull request as ready for review
October 2, 2026 22:37
Rodrigo Brandão (rodrigobr-msft)
requested a review
from a team
as a code owner
October 2, 2026 22:37
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Updates Microsoft Teams meeting start/end event handling to use the dedicated MeetingStartEventValue and MeetingEndEventValue models (instead of MeetingDetails) for improved schema correctness and type safety.
Changes:
- Swap meeting start/end handler parsing and type annotations to use
MeetingStartEventValue/MeetingEndEventValue. - Update tests to send event payloads matching the new meeting start/end schemas and assert on parsed fields.
- Update the Teams API usage manifest to reflect the newly consumed upstream symbols.
| File | Description |
|---|---|
| tests/hosting_msteams/test_meetings.py | Updates test payloads and assertions to validate MeetingStartEventValue / MeetingEndEventValue. |
| libraries/microsoft-agents-hosting-msteams/teams-api-usage-manifest.json | Replaces MeetingDetails usage with meeting start/end event value models. |
| libraries/microsoft-agents-hosting-msteams/microsoft_agents/hosting/msteams/meeting/route_handlers.py | Updates handler type signatures to the more specific meeting start/end models. |
| libraries/microsoft-agents-hosting-msteams/microsoft_agents/hosting/msteams/meeting/meeting.py | Updates route handlers to parse incoming activity values into the new models. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot started reviewing on behalf of
Rodrigo Brandão (rodrigobr-msft)
October 2, 2026 23:08
View session
Michael Yamamoto (miyamamo)
approved these changes
Oct 2, 2026
Kyle Rohn (kylerohn-msft)
approved these changes
Oct 2, 2026
Rodrigo Brandão (rodrigobr-msft)
enabled auto-merge (squash)
October 2, 2026 23:12
Axel Suárez (axelsrz)
approved these changes
Oct 2, 2026
MattB (MattB-msft)
approved these changes
Oct 2, 2026
Rodrigo Brandão (rodrigobr-msft)
deleted the
users/robrandao/meeting-details
branch
October 2, 2026 23:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This pull request updates the way meeting start and end events are handled in the Microsoft Teams agent extension. The main change is to use the more specific
MeetingStartEventValueandMeetingEndEventValuemodels instead of the genericMeetingDetailsmodel. This ensures that meeting event handlers receive the correct data structures and improves type safety. The tests have also been updated to reflect these changes and to validate the new models.Meeting event handler improvements:
MeetingStartEventValueandMeetingEndEventValuemodels, respectively, instead of the genericMeetingDetailsmodel. This affects both the handler signatures and the models used to parse incoming event data. [1] [2] [3] [4] [5] [6]Test updates: