Skip to content

Using the appropriate models for MSTeams meeting start/end routes - #619

Merged
Rodrigo Brandão (rodrigobr-msft) merged 3 commits into
mainfrom
users/robrandao/meeting-details
Oct 2, 2026
Merged

Rodrigo Brandão (rodrigobr-msft) merged 3 commits into
mainfrom
users/robrandao/meeting-details

Conversation

@rodrigobr-msft

Copy link
Copy Markdown
Contributor

This pull request updates the way meeting start and end events are handled in the Microsoft Teams agent extension. The main change is to use the more specific MeetingStartEventValue and MeetingEndEventValue models instead of the generic MeetingDetails model. This ensures that meeting event handlers receive the correct data structures and improves type safety. The tests have also been updated to reflect these changes and to validate the new models.

Meeting event handler improvements:

  • Meeting start and end handlers now use MeetingStartEventValue and MeetingEndEventValue models, respectively, instead of the generic MeetingDetails model. This affects both the handler signatures and the models used to parse incoming event data. [1] [2] [3] [4] [5] [6]

Test updates:

  • Tests have been updated to use the new event value models. Test helper functions now return payloads matching the expected schema, and test assertions check for the correct model types and field values. [1] [2]

@rodrigobr-msft
Rodrigo Brandão (rodrigobr-msft) marked this pull request as ready for review October 2, 2026 22:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

Updates Microsoft Teams meeting start/end event handling to use the dedicated MeetingStartEventValue and MeetingEndEventValue models (instead of MeetingDetails) for improved schema correctness and type safety.

Changes:

  • Swap meeting start/end handler parsing and type annotations to use MeetingStartEventValue / MeetingEndEventValue.
  • Update tests to send event payloads matching the new meeting start/end schemas and assert on parsed fields.
  • Update the Teams API usage manifest to reflect the newly consumed upstream symbols.
File Description
tests/​hosting_msteams/​test_meetings.py Updates test payloads and assertions to validate MeetingStartEventValue / MeetingEndEventValue.
libraries/​microsoft-agents-hosting-msteams/​teams-api-usage-manifest.json Replaces MeetingDetails usage with meeting start/end event value models.
libraries/​microsoft-agents-hosting-msteams/​microsoft_agents/​hosting/​msteams/​meeting/​route_handlers.py Updates handler type signatures to the more specific meeting start/end models.
libraries/​microsoft-agents-hosting-msteams/​microsoft_agents/​hosting/​msteams/​meeting/​meeting.py Updates route handlers to parse incoming activity values into the new models.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/hosting_msteams/test_meetings.py
Comment thread tests/hosting_msteams/test_meetings.py
@rodrigobr-msft
Rodrigo Brandão (rodrigobr-msft) merged commit 9faa45c into main Oct 2, 2026
10 checks passed
@rodrigobr-msft
Rodrigo Brandão (rodrigobr-msft) deleted the users/robrandao/meeting-details branch October 2, 2026 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants