Repository navigation
fix: add report export and run-aware types to the eject engine surface - #476
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
com.metaobjects.generator.EmitsReportExportandcom.metaobjects.generator.RunAwareto theenginesurface infixtures/generator-registry-conformance/registry.jsonfor the Java and Kotlin generator entries that declare that list.EjectContractTestforcodegen-kotlinandmaven-plugin.Validation
Risk Assessment
✅ Low: Four-line manifest change adds the two exact interfaces named in the failing Java and Kotlin EjectContractTest messages to the engine surface; both exist as public codegen-base types, so the stale-entry checks hold too.
Testing
Drove the reported failure: restoring the pre-fix registry.json makes the depth test fail with the exact messages from the intent, and the committed fixture makes it pass in both maven-plugin and codegen-kotlin. Broader registry-consuming suites (Java codegen-spring/maven-plugin, Kotlin, TS codegen/cli, Python eject) pass. Not a full ci-local run across every port; the scope of regression is the registry consumers plus the full maven-plugin/codegen-spring suites. Result: go.
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
scripts/ci-local.sh --only ts-fast --only ts-unit --strict-toolchainsgit show be3afd9d2:fixtures/generator-registry-conformance/registry.json swapped in, thenmvn -o -pl maven-plugin test -Dtest=EjectContractTest#depthAnOwnedCopyReferencesOnlyTheEngineSurface→ FAILS with the reported routes/report-export messages (reproduction), then restored HEAD copymvn -pl maven-plugin test -Dtest=EjectContractTest(server/java) → 7/7 passmvn -pl codegen-kotlin test -Dtest=EjectContractTest→ 7/7 pass (network deps, isolated -Dmaven.repo.local=/tmp)mvn -pl codegen-spring,codegen-kotlin test -Dtest=GeneratorRegistryConformanceTest,EjectContractTest→ all passmvn -pl maven-plugin,codegen-spring test(full suites) → 260 maven-plugin tests and codegen-spring suite greenbun teston codegen-ts generator-registry-conformance + api-docs-cross-port-conformance and cli catalog-conformance + skill-catalog-grounding → 76 passuv run pyteston server/python eject_contract, generator_registry conformance, test_eject_alone → 50 passBaselinescripts/ci-local.sh --only ts-fast --only ts-unitalready green (per context)Worktree clean after run (git status empty)✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.