Repository navigation
Conversation
The fork kept upstream's module path and was consumed through a go.mod replace, so every import site read go-resty while actually meaning this fork. Declaring the fork's own path lets consumers require it directly and drop the replace masquerade. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
README installation and usage examples still reference the old module path.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Renames the Go module from github.com/go-resty/resty/v2 to github.com/meshy-dev/resty/v2 and updates related imports and Bazel metadata.
Changes:
- Updates the
go.modmodule path. - Updates Go self-imports.
- Updates Bazel import paths and Gazelle metadata.
File summaries
| File | Description |
|---|---|
util_curl.go |
Updates the shellescape import. |
shellescape/BUILD.bazel |
Updates the shellescape import path. |
go.mod |
Declares the new module path. |
example_test.go |
Updates the root package import. |
BUILD.bazel |
Updates root Bazel metadata. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Doc links to upstream godoc are retained on purpose — they document upstream API. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
| # Go Modules | ||
| require github.com/go-resty/resty/v2 v2.16.5 | ||
| # Go Modules (this fork declares its own module path) | ||
| require github.com/meshy-dev/resty/v2 latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames the module from
github.com/go-resty/resty/v2togithub.com/meshy-dev/resty/v2.The fork kept upstream's module path, so meshyd consumed it through a
replacedirective and every import site readgithub.com/go-resty/resty/v2while actually meaning this fork. Declaring the fork's own path removes that masquerade: consumersrequire github.com/meshy-dev/resty/v2directly and drop the replace.Changes: the
moduleline in go.mod, the two self-imports (util_curl.go→shellescape,example_test.go→ root), and the two Bazelimportpathattributes. Doc-comment links to upstream godoc are left as-is — they document upstream API.Consumer impact
github.com/meshy-dev/resty/v2and removing the replace (will go into taichi-dev/meshyd#6129).Testing
go build ./...,go vet ./..., fullgo test -race ./...pass under the new path.🤖 Generated with Claude Code