You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Widen SingleStoreBulkUpdateResult row counts to long - #29
Medium Risk
Breaking public API on an experimental type and a behavioral change in how affected rows are read for the UPDATE phase; logic is localized to bulk update but callers assigning to int will need updates.
Overview Breaking change to the experimental bulk-update API: SingleStoreBulkUpdateResult.RowsMatched is now long? and RowsAffected is now long, so match and affected counts above int.MaxValue are reported exactly instead of overflowing or being clamped.
Implementation follows that contract: the optional match COUNT(*) uses Convert.ToInt64, and the UPDATE phase reads SingleStoreDataReader.RealRecordsAffected after fully consuming the reader (instead of ExecuteNonQuery, which caps at int.MaxValue). Bulk-update logging and release notes/tutorial text are updated accordingly; RowsStaged stays int (client-side staging count).
The reason will be displayed to describe this comment to others. Learn more.
Approved. Cursor Bugbot completed successfully with no findings that need human review, and Cursor Security Agent was not present so that signal was skipped. No approval policy required additional review.
Sent by Cursor Approval Agent: Pull Request Router and Approver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an extension to the PR #28.