Repository navigation
Conversation
|
Tests fail because the docker images still use I am now wondering if we should just move |
|
I will probably keep it in our docker images anyway because it's nice to have. But I agree it'd be nice for pyoptsparse to handle. Right now we have a chicken and egg situation where we've merged a PR updating the unopy version in the docker images, but those new images won't be published until our docker CI passes, which won't happen until this PR is merged. Handling the unopy installation in the pyoptsparse CI would fix this.
Not super familiar with the precedent in other pyOptSparse wrappers, but I think we should only be storing default options in pyOptSparse if we are deliberately overriding that default, or we alter the behaviour of the option (e.g the |
|
Putting myself on the spot because I triggered this whole roadblock when I first added UNO to docker without realizing that If we do this, then it is also much easier to maintain the current set of default options - whatever they may be. |
The Uno options in pyOptSparse are already quite minimal 😅 But Uno is under active development and the option set changes pretty much daily. That said, the tolerances that changed from Uno v2.9.0 to v2.9.1 shouldn't change any more (sorry, I should have published a minor release because of the breaking changes). |
Purpose
This PR updates the pyUno options. The tolerances associated with loose tolerances were changed/renamed in unopy v0.4.15/Uno v2.9.1.
Expected time until merged
Type of change
Testing
Checklist
ruff checkandruff formatto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable