Skip to content

Fix CODEOWNERS - #497

Merged
A-CGray merged 1 commit into
mainfrom
A-CGray-patch-1
Sep 30, 2026
Merged

A-CGray merged 1 commit into
mainfrom
A-CGray-patch-1

Conversation

@A-CGray

@A-CGray A-CGray commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Purpose

Currently, only @marcomangano is being assigned as a PR reviewer, despite @ewu63 and @mdolab/pyoptsparse_maintainers being listed as code owners. I think this may be because we currently have all 3 on separate lines with * permissions. Based on this example in the github docs, I think each new line in the codeowners line overrides any previous lines with matching permissions. So the * @marcomangano line overwrites the * @ewu63 and * @mdolab/pyoptsparse_maintainers lines, leaving him as the only recognised code owner. The fix is to put everyone on the same line.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run ruff check and ruff format to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray
A-CGray requested a review from ewu63 September 29, 2026 15:23
@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.22%. Comparing base (43e2e55) to head (7854511).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   54.22%   54.22%           
=======================================
  Files           1        1           
  Lines         225      225           
=======================================
  Hits          122      122           
  Misses        103      103           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@A-CGray
A-CGray merged commit 775fac6 into main Sep 30, 2026
14 checks passed
@A-CGray
A-CGray deleted the A-CGray-patch-1 branch September 30, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants