[maxthomas95]

Summary

July finding C-3, still open in docs/REVIEW_2026-11-09.md.

The New Session and New Environment dialogs called onCreate and closed immediately. A failed SSH launch, a declined Vault login or a persistence error was reported only by a toast, and everything typed was gone. A worktree created just before a failed launch was left behind.

• Handlers report the outcome. handleCreateSession, handleCreateEnvironment and handleUpdateEnvironment resolve to true or false. Their existing error toasts are unchanged.
• Dialogs wait. Both dialogs await the result and close only on success. On failure every field stays as it was. The create buttons are disabled while a submit is pending and a second submit is ignored. Cancel and close stay available.
• Worktree cleanup. A worktree created for an attempt that then fails is removed, so a retry does not fail on the existing path. If the removal itself fails, the dialog says where the worktree was left.
• Docs. sessions.md and environments.md describe the behaviour.

The four paths in the session dialog that launch a session are covered: plain create, new folder, and the two clone paths.

Test plan

• npx tsc --noEmit
• npx eslint on touched files
• npx vitest run — 2404 passed; 2 failed, both the known Windows-host real-shell/PTY tests
• Manual: New Session against an unreachable SSH host — error toast, dialog still open with directory, label, flags and env intact; fix the environment and Create works
• Manual: New Session with "create worktree" against a failing launch — the worktree is gone afterwards and a retry succeeds
• Manual: decline a Vault login from New Session — the dialog stays open
• Manual: New Environment with a duplicate or invalid config — the dialog stays open

Out of scope

• A mount test for NewSessionDialog (it needs a large electronAPI harness; the close-on-success step is covered through the shared helper).
• Showing the failure inline in the dialog instead of a toast.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate failed

Failed conditions
18.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud