Conversation
Both `npm audit --audit-level=high` steps had continue-on-error: true, so the Dependency Audit job could never go red. Evidence: PR #61's Security Scan run printed several "Severity: high" findings and the job concluded success; the check stayed green throughout a period when GitHub showed one critical and six high alerts. A check that cannot fail is not evidence of anything -- the F-7 shape -- and it is what any notification layered on this workflow would have reported as "Security CI passed". Removes both flags. Verified: both audits exit 0 today (root: 0 vulnerabilities after #63; web: 0 high/critical), so this does not turn the check red now, only when a new high or critical advisory lands. Dependency Audit is not one of the two required status checks (Build Frontend, Test Smart Contracts), so a red run is a signal, never a merge block. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
continue-on-error: truefrom bothnpm audit --audit-level=highsteps insecurity.yml, so the Dependency Audit job can actually go red.Why
With the flag set, the job passed unconditionally. Evidence from PR #61's Security Scan run (before the deps fix in #63): the audit step printed several
Severity: highfindings and the job's conclusion was success. It stayed green while GitHub showed one critical and six high alerts. A check that can't fail isn't evidence of anything, which is the F-7 shape, and it's what a Slack "Security CI" summary (proposed by Hillary) would have reported as all-clear. This should land before any such notification.Safe to merge now
Build FrontendandTest Smart Contractsare), so a red run is a signal and never blocks a merge.Trade-off worth knowing
A new advisory can turn Dependency Audit red on an unrelated PR. That's the intended signal, but it can look like noise. The weekly Monday run means it's caught even without PR traffic.
npm auditalso depends on the registry being reachable, so a transient network failure will show as red too..github/workflows/is CODEOWNERS-protected (Hillary).🤖 Generated with Claude Code