Repository navigation
Prepare ID 0.5.2 hardening release - #4
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cab282a7dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Legacy list policies from earlier releases are normalized in memory during validation and export. Their source files remain unchanged and their restrictions remain effective. `--allow-unfiltered` only permits a missing policy in a reviewed legacy workflow; it cannot bypass an invalid policy. | ||
|
|
||
| Generating or exporting a file does not upload it. Source profiles remain under your control. | ||
| Review the resulting export before attaching it to another tool. See the [privacy model](docs/PRIVACY.md), [policy schema](docs/PRIVACY_POLICY_V1.md), and [threat model](docs/THREAT_MODEL.md). |
There was a problem hiding this comment.
When users follow the Share path in docs/QUICKSTART.md, they validate a privacy policy and then create interop.v1.json, but scripts/export_interop_v1.py never loads that policy and therefore includes fields marked local_only or left unlisted. This rewrite removes the previous explicit warning that interop and soul artifacts are not privacy-filtered, so readers may treat policy validation as protecting those artifacts; explicitly limit this review guidance to compact/MCP output and restore the warning for unfiltered artifacts.
AGENTS.md reference: AGENTS.md:L14-L14
Useful? React with 👍 / 👎.
| idctl export-interop --owner-id demo | ||
| idctl export-compact --owner-id demo | ||
| idctl validate-compact --owner-id demo | ||
| idctl diff --owner-id demo --since 7d |
There was a problem hiding this comment.
In the documented fresh-directory flow, no Git repository or baseline commit is created before this command. idctl diff --since 7d requires Git history and exits with status 2 (no git revision found before ...), so the advertised five-minute sequence ends in an error for a new user; initialize and commit a baseline first, or move this command to an optional Git-backed workflow.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
| Requires Python 3.11 or newer. | ||
|
|
||
| ```sh | ||
| uv tool install id-protocol |
There was a problem hiding this comment.
The preceding requirement now says only Python 3.11+ is needed, but the first installation command invokes the separate uv executable. On a normal Python installation without uv, the quickstart fails immediately with uv: command not found; either retain uv as an explicit prerequisite with installation guidance or provide a pip/pipx command.
Useful? React with 👍 / 👎.
ID 0.5.1 documented stale companion versions and exposed registry files for an MCP server the package does not run. This prepares 0.5.2 with an honest adapter boundary, current SET compatibility, a smaller context handshake, and an installed-user path that can be reproduced from the wheel.
What changed
idctl redactValidation
make validate— 53 tests pass; generated artifacts validatemake drift-check— cleanmake coverage— 78%twine checkpassesThe checked-in owner profile remains unchanged. Validation reports its existing stale review dates; this release does not renew them without a content review.