Repository navigation
feat: use video.js audio player - #102
Merged
Merged
Conversation
10.0.0, not 10.0.1: npm min-release-age setting refuses anything under three days old.
Neutral audio skin replaces browser controls. Same audio element underneath, so line highlight, click-to-seek and jump-to-top are unchanged. Skin follows day and night mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video.js v10 neutral audio skin replaces the browser's own audio controls on chant pages: play, skip 10s, time, seek bar, volume, speed.
Same audio element underneath, so line highlight, click-to-seek, auto-scroll and jump-to-top are unchanged. Skin follows day and night mode.
200 tests, including new render test for the player. Checked in clean headless browser: seek, highlight, skin play button, night colours, jump-to-top.
Cost: chant page script 185 kB (56 kB gzipped), up from about 3 kB. Styles 58 kB (7.5 kB gzipped).
Version 10.0.0, one patch behind latest: npm setting refuses packages under three days old.