Repository navigation
Conversation
Assisted-by: Claude (Anthropic)
Add persist-credentials: false to the checkout step, document the packages: write permission, and set a 7-day dependabot cooldown (renaming the actions group to github-actions). zizmor --persona=pedantic now reports no findings. Assisted-by: Claude (Anthropic)
Reduces the risk of resolving a recently published (and potentially compromised) conda-forge or PyPI package on future pixi lock updates. Assisted-by: Claude (Anthropic)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-images.yamlto full commit SHAs (with version comments), viaactions-up.persist-credentials: falseto theactions/checkoutstep (zizmorartipacked).packages: writejob permission (zizmorundocumented-permissions).actionstogithub-actions(zizmordependabot-cooldown).exclude-newercooldown to the pixi[workspace]table inpixi.toml, so futurepixi.lockupdates won't resolve a conda-forge/PyPI package published in the last week.uvx zizmor --persona=pedantic .githubreports no findings after these changes.Major version changes
actions-upbumped every pinned action by a major version (all releases are older than the 7-day cooldown):actions/checkoutv6 -> v7.0.1docker/setup-buildx-actionv3 -> v4.2.0docker/login-actionv3 -> v4.6.0docker/metadata-actionv5 -> v6.2.0docker/build-push-actionv6 -> v7.3.0Each SHA was independently verified against the corresponding GitHub release tag. No changelog-breaking inputs/outputs for this workflow's usage were found, but please double check the image build/push still behaves as expected since this is the only workflow in the repo.
Note: there is an existing open Dependabot PR (
dependabot/github_actions/actions-6534b7915f) bumping the same actions to unpinned major versions. It will likely go stale/be superseded once this merges; Dependabot should recreate it against the new pinned SHAs on its next run if there's anything further to bump.Held-back items
if: github.event_name != 'pull_request', so there's no untrusted-code-with-deploy-credentials exposure today. Splitting build/push would require shuttling a multi-GB image through GitHub Actions artifacts between jobs, which is impractical for an image this size and risks breaking the pipeline for no real security gain here. Left as-is; flagging in case a registry-mirroring or layer-caching strategy is wanted later.zizmor ignores
None added — all findings were fixed directly rather than ignored.
Verification
uvx zizmor --persona=pedantic .github-> no findings.uses:refs are full 40-character SHAs with a version comment; verified none are tags or branches.