feat: celebrate employee ornament on activation - #39
Merged
Conversation
Replace the decorative aria-hidden span with a semantic button that plays a one-shot squash/bounce celebration with blue-accent glow on activation, while keeping the continuous float animation, sprite geometry, and all surrounding copy, layout, tokens, and assets unchanged. - button.koan-ornament with aria-label "Celebrate enlightenment"; SVG aria-hidden - 280ms employeeCelebrate keyframes on the SVG (wrapper float untouched) - focus-visible outline using the existing --focus-ring token - prefers-reduced-motion: float and celebration animation/glow disabled, button and focus behavior retained - minimal JS replays the class on each activation and removes it after the effect (animationend + timeout fallback)
Commit 3383b38 accidentally inserted a duplicated "12-5.373 12-12 " segment into the MEGA contact icon's path data. Restore the path d attribute exactly to its base-main value. Also expand the koan-ornament button's pointer target to 24px wide with a transparent ::before pseudo-element (4px horizontal outsets), without scaling or repositioning the visible 16x32 SVG. Celebration behavior, semantics, keyboard/focus, reduced-motion, and PWA behavior unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the floating JRPG employee a keyboard-accessible “Celebrate enlightenment” button. Click, tap, Enter, or Space replays a short 280ms squash/rebound with an accent glow; the existing float remains on the wrapper. The visible sprite remains 16×32, while its transparent pointer target expands to 24×32.
Fixes # — not applicable; owner-approved interaction enhancement.
Type of change
Validation
Manual branch-browser validation confirmed native button semantics and accessible name, 2px keyboard focus outline, pointer activation including the expanded hit area, click replay/cleanup, and reduced-motion behavior (float, celebration animation, and glow disabled while the button remains usable).
Remaining validation gate: existing PR CI runs static pre-commit checks and service-worker syntax only; it does not execute browser interaction or reduced-motion tests. This PR intentionally does not broaden CI. Owner review must accept that coverage limitation before merge.
Impact and rollout
Self-contained in
makeitworkcloud/www: onlymakeitwork.cloud/index.htmlchanges. The source is directly deployed; no producers, consumers, pins, generated copies, PWA behavior, service worker, metadata, links, assets, onion-site content, or workflow configuration change. After an owner-approved merge,deploy.ymlautomatically runs static checks, syncs both site directories to S3, and purges Cloudflare. Rollback is a revert followed by the same automatic deployment.Safety and secrets
This change was materially produced by an AI agent under owner direction.