feat(opencode): add SDLC reviewer subagents - #88
Merged
Conversation
Add adversarial-code-reviewer, infra-security-reviewer, qa-engineer, and release-engineer subagents following the recruiter-resume-reviewer pattern: read-only, required inputs, and ranked-findings verdicts. Gate non-trivial pull requests through adversarial review in the code-touching primary agents, document the reviewer class in the instruction architecture, and bump the chart version to 0.1.68.
Document the specialized reviewer class and the code-touching primary review gate in the instruction architecture, and update the chart README's packaged configuration description.
Chart CI passedRepository hygiene and Helm validation passed. View the workflow run. |
Add a read-only documentation drafting and consistency-check subagent scoped to standalone repository documentation, extend the primary review gate with a conditional docs-writer dispatch, and document the role in the instruction architecture and chart README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds five specialized SDLC subagents to
opencode-server, extending the provenrecruiter-resume-reviewerpattern (read-only,edit/bashdenied, required inputs withHOLD/BLOCKEDon absence, fresh-context independence, ranked-findings verdicts) from career documents to delivery work:adversarial-code-reviewer— hostile pre-PR review of any non-trivial completed implementation (openai/gpt-5.6-terra,xhigh)infra-security-reviewer— pre-merge security posture review of infrastructure-affecting changes; reviews secret shape, never content (openai/gpt-5.6-terra,xhigh)qa-engineer— test design, CI-coverage mapping, validation-gap analysis, failing-check triage; read-only analyst (openai/gpt-5.6-luna)release-engineer— pre-merge release readiness: version/pin checks, consistency, delivery-chain enumeration, release-note draft (kimi-for-coding/k3-256k,high)docs-writer— drafts, revises, and consistency-checks standalone repository documentation from parent-supplied source; returns complete ready-to-commit Markdown, flags unverified claims; excluded fromagent-knowledgesubtrees and policy/instruction files (kimi-for-coding/k3-256k,high)The five code-touching primary agents (
default,makeitwork,xnoto,career,teacher) gain a shared pre-pull-request review-gate bullet with conditional dispatches for validation, release, and documentation risk; the lifestyle primaries intentionally do not, since they do not author code, chart, or workflow changes — rationale documented indocs/agent-instruction-architecture.md, which also records the specialized-subagent class. Chart version bumped0.1.67→0.1.68.No driving issue; owner-approved recommendation from this session.
Type of change
Validation
CI is the validation environment. This pull request's repository-hygiene, Helm-rendering, and packaging checks validate the authored chart content; they are being monitored to terminal status.
templates/configmap.yamlandtemplates/deployment.yaml(no template changes required)Intentionally not validated here: runtime behavior of the new subagents (model routing, verdict protocols). That is functional verification performed only after merge → publication → GitOps pin → Argo CD reconciliation, as a separate stage.
Impact and rollout
opencode-serverchart0.1.68. Consumer: thekustomize-clusterOpenCode Application via the version pin.kustomize-clusterpin PR (auto-merge per current contract) → Argo CD reconciliation replaces the pod via the ConfigMap checksum (configuration is not hot-reloaded) → functional verification that a fresh session lists the five new subagents with correct models.agent-knowledgecommits are explicitly exempt, so routine knowledge maintenance is not taxed with high-reasoning reviews.Safety and secrets
AI-agent disclosure: materially produced by the
makeitworkOpenCode agent from an owner-approved recommendation; cache-sourced reads were freshness-verified against remotemain(bb522d47) before branching.