Repository navigation
Improve Fingerprint icon and provider menu - #861
Open
KaranocaVe wants to merge 3 commits into
Open
KaranocaVe wants to merge 3 commits into
KaranocaVe wants to merge 3 commits into
Conversation
Contributor
|
Thanks. The icon fields are the ones magpie reads: One thing blocks the merge. Reviewed at e2557b3; CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the fingerprint icon to the plugin list and sidebar, and fix the provider menu being clipped by the models panel. The menu now stays within the viewport and supports scrolling and keyboard navigation for long lists. Bump the package to 0.2.4 and derive the service version from package.json to keep the reported version in sync. Verified with 35 providers in a 420 x 450 viewport; the isolated rebuild, 37 tests, typecheck, and community Fingerprint check pass. Includes the fix from #862. Fixes #860.