Repository navigation
Drop GraphQL package requirements from reCAPTCHA endpoint config providers - #349
Open
lbajsarowicz wants to merge 1 commit into
Open
lbajsarowicz wants to merge 1 commit into
lbajsarowicz wants to merge 1 commit into
Conversation
…iders Compare webapi endpoints against resolver class names as string constants instead of importing the GraphQL resolver classes, and remove the module-contact-graph-ql and module-customer-graph-ql requirements. magento/magento2#41558
Author
|
@magento run all tests |
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
magento/module-re-captcha-contactrequiresmagento/module-contact-graph-qlandmagento/module-re-captcha-resend-confirmation-emailrequiresmagento/module-customer-graph-ql. The only use of those packages is aSomeResolver::classconstant compared againstEndpointInterface::getServiceClass(), which is a string.Magento\ReCaptchaCustomer\Model\WebapiConfigProviderreferences fourMagento\CustomerGraphQl\Model\Resolver\*classes the same way, without declaring the dependency at all.This PR replaces the
::classreferences with private string constants holding the same fully qualified names and removes the two GraphQL requirements fromcomposer.json. The compared values are byte-for-byte identical, so endpoint matching for REST and GraphQL requests does not change; the modules stop pulling GraphQL packages into a build that does not need them.Related Pull Requests / Issues
Part of magento/magento2#41558. A companion PR in this repository decouples the reCAPTCHA type modules from
Magento_ReCaptchaWebapiGraphQl.Manual testing scenarios
*-graph-qlpackages removed throughreplacein the rootcomposer.json; the three modules install andsetup:di:compilesucceeds.contactUsmutation without a token; the request is rejected with the reCAPTCHA error exactly as ondevelop. Repeat forresendConfirmationEmail,changeCustomerPassword,requestPasswordResetEmail,resetPassword,updateCustomerV2,generateCustomerTokenandcreateCustomerV2.Verification
PHPCS (Magento2 standard) on the changed PHP files: 0 errors, 0 warnings.
check_copyright_pr.php: all files pass.Contribution checklist