Repository navigation
fix(book-fold-phone): centre the default lens row as the manifest declares - #110
Merged
Merged
Conversation
…lares Both twins placed the first lens at x = 47.736 while the manifest (bound to lenswindow_lens_place.x) declares 47.808. 47.808 is the centred row, island_center_x - lens_pitch_x = 56.88 - 9.072, the same rule every device preset follows; 47.736 left the default row 0.072 mm off-centre. main.py's PARAM fallback and the graph node literal now state the manifest default (GOC-1 default-drift). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Aldo Ruiz Luna <aldo.ruiz.luna@gmail.com>
aldoruizluna
marked this pull request as ready for review
October 2, 2026 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Both twins now place the default lens row where the manifest declares it.
lens_first_center_x47.80847.73647.808main.py:182(PARAMfallback)lens_first_center_x47.80847.73647.808bookfold.graph.json:57(lenswindow_lens_place.x, the manifestbinding)Direction and why
The source now matches the manifest default.
lens_island_center_x − lens_pitch_x·(lens_count−1)/2 = 56.88 − 9.072.How this maps to GOC-1
GOC-1 (Digital Twins MES, Phase 2)
variables.jsonis only complete once yantra4d injects every declared parameter (RENDER_INJECT_FULL_PARAMS). This PR removes bothdefault-driftnotes for this cartridge (rule from hyperobjects-spec#30), on CadQuery and on the graph.Evidence
Tooling: hyperobjects-spec at
510efba(the #30 branch; CI pins3ff3736, which lacks the rule), CadQuery 2.8.0, macOS.The 84 notes break down as follows. None is a default-drift note and none involves the lens:
fold-state-*presets render the flat cover_half and hinge parts identically to the defaults. These presets set onlyfold_angle, which by design does not change an isolated flat part.The CadQuery and graph twins still agree on every default part; for example, camera_half is 43302.81 mm³ on both.
verificationis unchanged. One cartridge, two files.macOS green is not proof (AGENTS.md rule 4). The CI Linux render lane decides, and it is pending at the time of writing.
CI status (updated)
Linux CI on this head: manifest conformance (all cartridges): pass; render (cartridges changed in this PR) (book-fold-phone): pass; render scope: pass.
🤖 Generated with Claude Code