Repository navigation
fix(gridfinity): align baseplate_scad depth_units default with manifest - #107
Merged
Merged
Conversation
baseplate.scad fell back to depth_units = 2 while the manifest, both README tables, cup.scad and lid.scad all use 1. The top-level literal now states the manifest default, so a render that injects no parameters builds the 2 x 1 plate Studio shows (GOC-1 default-drift). The 2 x 2 plate stays one click away as the baseplate_std_scad preset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Aldo Ruiz Luna <aldo.ruiz.luna@gmail.com>
aldoruizluna
marked this pull request as ready for review
October 2, 2026 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
depth_units121gridfinity/baseplate.scad:31Direction and why
The source literal now follows the manifest default. Studio always sends the manifest-resolved set, so baseplate_scad users already see a 2 × 1 plate. These also say 1:
README.md:57;docs/README.md:89("all three | 1");cup.scad:29andlid.scad:33.The 2 × 2 plate is still available as the
baseplate_std_scadpreset (depth_units: 2).Licence note (NOTICE.md).
baseplate.scadis the clean-room OpenSCAD re-creation (#2). This PR edits one literal in MADFAM's own authoring. No upstream file is involved and no provenance changes.Clean-room record.
docs/CLEANROOM-VERIFICATION.mdrecordsbaseplate_scad/defaultat 84 × 84 (the old bare literal) and is a dated acceptance record, so I did not rewrite it. The new bare default reproduces that record's ownbaseplate_scad/p_depth_units_minrow exactly: 2808.10 mm³ (recorded 2808.099, 84 × 42 × 5).How this maps to GOC-1
GOC-1 (Digital Twins MES, Phase 2)
variables.jsonis only complete once yantra4d injects every declared parameter (RENDER_INJECT_FULL_PARAMS). This PR removes thedefault-driftnote for this cartridge (rule from hyperobjects-spec#30). Turning that flag on can then no longer change this cartridge's geometry for callers that send{}.Evidence
hyperobjects-spec at
510efba(the #30 branch; CI pins3ff3736, which lacks the rule), CadQuery 2.8.0, OpenSCAD 2026.02.13 (Manifold), macOS:The 2 notes are the existing thin-wall printability measurement on the CadQuery
baseplatemode, which this PR does not touch.verificationis unchanged. One cartridge, one file.A green macOS run does not prove the Linux result (AGENTS.md rule 4). CI's Linux render lane is the verdict, and it is still pending at the time of writing.
CI status (updated)
Linux CI on this head: manifest conformance (all cartridges): pass; render (cartridges changed in this PR) (gridfinity): pass; render scope (which cartridges changed): pass.
🤖 Generated with Claude Code