Repository navigation
fix(net-cup): align base_od source default with manifest - #103
Merged
Merged
Conversation
The PARAM fallback for `base_od` was 30.0 while the manifest, the docs table and the `two_inch` preset all use 35. The source literal now states the manifest default, so a render that injects no parameters builds what Studio shows (GOC-1 default-drift). The bare-default net_cup and lid_grommet bodies change accordingly; collar is unaffected (its base is clamped to top_r - 4). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Aldo Ruiz Luna <aldo.ruiz.luna@gmail.com>
aldoruizluna
marked this pull request as ready for review
October 2, 2026 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
net-cup/main.py:56: thePARAMfallback forbase_odnow equals the manifest default.base_od35.030.035.0Direction and why
The source literal now follows the manifest default. Studio always sends the manifest-resolved set, so 35 mm is already what users see. Three other places agree with 35:
docs/README.md("base_od| 35.0 mm"),two_inchpreset (base_od: 35),base_od <= top_od - 6(35 is within it at the defaulttop_od= 44).The module docstring still says a real 2-in cup has a "base OD ~30 mm". That line is a real-world reference, not the declared default, so I left it.
What changes in the bare-default geometry (a render that injects nothing):
net_cup: the base widens from 30 to 35 mm.lid_grommet:base_r = max(17.5, 22-5)gives 17.5 instead of 17.collar: unchanged, becausemax(17.5, 22-4) = 18.The body count stays 1.
How this maps to GOC-1
GOC-1 (Digital Twins MES, Phase 2)
variables.jsonis complete only when yantra4d injects every declared parameter (RENDER_INJECT_FULL_PARAMS). This PR removes this cartridge'sdefault-driftnote (the rule comes from hyperobjects-spec#30), so turning the flag on cannot change the geometry for callers that send{}.Evidence
Environment: hyperobjects-spec at
510efba(the #30 branch; CI pins3ff3736, which lacks the rule), CadQuery 2.8.0, macOS.A green macOS run is not proof (AGENTS.md rule 4). The CI Linux render lane decides, and it is still pending at the time of writing.
verificationis unchanged. The PR touches one cartridge and one file.CI status (updated)
Linux CI on this head: manifest conformance (all cartridges): pass; render (cartridges changed in this PR) (net-cup): pass; render scope (which cartridges changed): pass.
🤖 Generated with Claude Code