fix(cabinet-bin): align div_x source default with manifest - #102
Merged
Merged
Conversation
The PARAM fallback for `div_x` was 0 while the manifest (and the docs table) declare 1. divided_bin already substituted one centred divider when the count was 0, and div_x=1 places that same divider at x=0, so the default geometry is unchanged; the source literal now states the manifest default (GOC-1 default-drift). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Aldo Ruiz Luna <aldo.ruiz.luna@gmail.com>
aldoruizluna
marked this pull request as ready for review
October 2, 2026 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
cabinet-bin/main.py:50: thePARAMfallback fordiv_xnow equals the manifest default.div_x101Direction and why
The source literal now follows the manifest default. Studio always sends the manifest-resolved set, so users already see 1.
docs/README.mdalready documents 1. The default geometry does not change:divided_binreadsdiv_x.build_divided_binalready substituted one centred divider (x = 0).div_x = 1places its single divider at-inner_w/2 + inner_w/2 = 0, the same wall.How this maps to GOC-1
GOC-1 (Digital Twins MES, Phase 2)
variables.jsonis only complete once yantra4d injects every declared parameter (RENDER_INJECT_FULL_PARAMS). This PR removes thedefault-driftnote for this cartridge (rule from hyperobjects-spec#30), so turning that flag on cannot change this cartridge's geometry for callers that send{}.Evidence
Run with hyperobjects-spec at
510efba(the #30 branch; CI pins3ff3736, which lacks the rule), CadQuery 2.8.0, macOS:A green render on macOS does not prove the Linux render (AGENTS.md rule 4); the CI Linux render lane decides. That lane had not run when this was written. No
verificationchange. One cartridge, one file.CI status (updated)
Linux CI on this head: manifest conformance (all cartridges): pass; render (cartridges changed in this PR) (cabinet-bin): pass; render scope (which cartridges changed): pass.
🤖 Generated with Claude Code